Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LOGinstruments #656

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

kawa-sanmyaku
Copy link
Contributor

@kawa-sanmyaku kawa-sanmyaku commented Apr 26, 2024

MOD builds fail, I might need some help with that >.<
@taji feel free to test the modules once artifacts are produced here

@kawa-sanmyaku
Copy link
Contributor Author

kawa-sanmyaku commented Apr 26, 2024

Only linux artifacts were generated; sorry about that, not sure what happened there

EDIT: oh dear, lol

@kawa-sanmyaku
Copy link
Contributor Author

A screenshot from a local build
image

plugins/plugins.cpp Outdated Show resolved Hide resolved
src/custom/dep.cpp Outdated Show resolved Hide resolved
@taji
Copy link

taji commented Apr 27, 2024

MOD builds fail, I might need some help with that >.< Success! @taji feel free to test the modules once artifacts are produced here, or check the artifacts in the fork EDIT: nvm, the artifacts are gone after a workflow re-run of failed jobs :( woe

@washikano : I'll monitor this PR thread and test when artifacts are available. Thanks. :-)

@taji
Copy link

taji commented Jul 8, 2024

@washikano, checking in. Any progress on this? I see that the CI is still stalled?

@kawa-sanmyaku
Copy link
Contributor Author

@washikano, checking in. Any progress on this? I see that the CI is still stalled?

Sorry, the modaudio build fails, and haven't had time to look into why :( to be completely honest last time I had an issue with the modaudio builds I was completely clueless, I'll see if I can look into it this weekend and merge main

The rest of the builds seem to build fine though ^^ you can download one those artifacts for now if you like

Don't expect this PR to be merged soon/this year though, there are other priorities

@falkTX
Copy link
Contributor

falkTX commented Jul 15, 2024

CI has been fixed, please rebase against the latest main branch.

@falkTX
Copy link
Contributor

falkTX commented Jul 16, 2024

that modaudio one is an odd one, that code seems to be optimized in such a way that triggers the use of libgomp, which is used for math stuff.
nothing for you to do, I will have to check where this lib is available and make sure it is present in the post-build steps

@falkTX falkTX force-pushed the main branch 4 times, most recently from 58e55b0 to 52d71a1 Compare October 6, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants