Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial work for PdArray #658

Merged
merged 10 commits into from
May 4, 2024
Merged

initial work for PdArray #658

merged 10 commits into from
May 4, 2024

Conversation

dromer
Copy link
Collaborator

@dromer dromer commented Apr 27, 2024

Not working yet, getting stuck at linker stage:

/bin/ld: ../../plugins/plugins.a(Widgets.cpp.o): in function `TextBox::draw(rack::widget::Widget::DrawArgs const&)':
Widgets.cpp:(.text._ZN7TextBox4drawERKN4rack6widget6Widget8DrawArgsE+0x0): multiple definition of `TextBox::draw(rack::widget::Widget::DrawArgs const&)'; ../../plugins/plugins.a(Widgets.cpp.o):Widgets.cpp:(.text._ZN7TextBox4drawERKN4rack6widget6Widget8DrawArgsE+0x0): first defined here
/bin/ld: ../../plugins/plugins.a(Widgets.cpp.o): in function `TextBox::draw(rack::widget::Widget::DrawArgs const&)':
Widgets.cpp:(.text._ZN7TextBox4drawERKN4rack6widget6Widget8DrawArgsE+0x0): multiple definition of `TextBox::draw(rack::widget::Widget::DrawArgs const&)'; ../../plugins/plugins.a(Widgets.cpp.o):Widgets.cpp:(.text._ZN7TextBox4drawERKN4rack6widget6Widget8DrawArgsE+0x0): first defined here
Creating CLAP plugin for Cardinal
Creating VST3 plugin for Cardinal
/bin/ld: ../../plugins/plugins.a(Widgets.cpp.o): in function `TextBox::draw(rack::widget::Widget::DrawArgs const&)':
Widgets.cpp:(.text._ZN7TextBox4drawERKN4rack6widget6Widget8DrawArgsE+0x0): multiple definition of `TextBox::draw(rack::widget::Widget::DrawArgs const&)'; ../../plugins/plugins.a(Widgets.cpp.o):Widgets.cpp:(.text._ZN7TextBox4drawERKN4rack6widget6Widget8DrawArgsE+0x0): first defined here
/bin/ld: ../../plugins/plugins.a(Widgets.cpp.o): in function `TextBox::draw(rack::widget::Widget::DrawArgs const&)':
Widgets.cpp:(.text._ZN7TextBox4drawERKN4rack6widget6Widget8DrawArgsE+0x0): multiple definition of `TextBox::draw(rack::widget::Widget::DrawArgs const&)'; ../../plugins/plugins.a(Widgets.cpp.o):Widgets.cpp:(.text._ZN7TextBox4drawERKN4rack6widget6Widget8DrawArgsE+0x0): first defined here
collect2: error: ld returned 1 exit status
make[2]: *** [../../dpf/Makefile.plugins.mk:515: ../../bin/Cardinal] Error 1
make[2]: *** Waiting for unfinished jobs....
collect2: error: ld returned 1 exit status
make[2]: *** [../../dpf/Makefile.plugins.mk:558: ../../bin/Cardinal.lv2/Cardinal.so] Error 1
collect2: error: ld returned 1 exit status
make[2]: *** [../../dpf/Makefile.plugins.mk:712: ../../bin/Cardinal.clap/Cardinal.clap] Error 1
collect2: error: ld returned 1 exit status
make[2]: *** [../../dpf/Makefile.plugins.mk:690: ../../bin/Cardinal.vst3/Contents/x86_64-linux/Cardinal.so] Error 1
make[2]: Leaving directory '/home/dreamer/Sources/_audio/_DISTRHO/Cardinal/src/Cardinal'
make[1]: *** [Makefile:128: all] Error 2
make[1]: Leaving directory '/home/dreamer/Sources/_audio/_DISTRHO/Cardinal/src'
make: *** [Makefile:137: cardinal] Error 2

The MAX_POLY_CHANNELS is also not ideal, can probably be done differently?

@dromer
Copy link
Collaborator Author

dromer commented Apr 27, 2024

Now builds .. but segfaults ..

@falkTX
Copy link
Contributor

falkTX commented May 3, 2024

this needs some symbol conflict fixing, LTO reports the problems.
also the drwav part too.

that should help with the crashes.

@dromer
Copy link
Collaborator Author

dromer commented May 3, 2024

Still needs some tweaking for the Array panel darkMode:

dromer and others added 5 commits May 3, 2024 11:01
Signed-off-by: falkTX <falktx@falktx.com>
Signed-off-by: falkTX <falktx@falktx.com>
Signed-off-by: falkTX <falktx@falktx.com>
@falkTX falkTX merged commit 646f01d into main May 4, 2024
35 of 40 checks passed
@falkTX falkTX deleted the feature/add-PdArray branch May 4, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants