Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Meander to v2.0.34 #759

Merged
merged 2 commits into from
Nov 30, 2024
Merged

update Meander to v2.0.34 #759

merged 2 commits into from
Nov 30, 2024

Conversation

dromer
Copy link
Collaborator

@dromer dromer commented Nov 21, 2024

No description provided.

@dromer dromer force-pushed the update/Meander-to-v2.0.34 branch from 7b6a00d to db1b839 Compare November 21, 2024 21:24
@dromer
Copy link
Collaborator Author

dromer commented Nov 22, 2024

Hmm, wonder what's going wrong with the plugin-validation 🤔

@falkTX
Copy link
Contributor

falkTX commented Nov 26, 2024

pluginval does not fail right away, for giving the chance to report multiple issues.

I see them in the logs:


[dpf] >>>>>>>>>>>>>>>>> LOADING module PS-PurrSoftware : ModeScaleQuant
==164445== Conditional jump or move depends on uninitialised value(s)
==164445==    at 0x773C5E3: __strcpy_chk (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==164445==    by 0x1DA7168: strcpy (string_fortified.h:90)
==164445==    by 0x1DA7168: copyHarmonyTypeToActiveHarmonyType (MSQ_data_and_functions.hpp:497)
==164445==    by 0x1DA7168: ModeScaleQuantMusicStructuresInitialize (MSQ_data_and_functions.hpp:509)
==164445==    by 0x1DA7168: ModeScaleQuant::ModeScaleQuant() (ModeScaleQuant.cpp:953)
==164445==    by 0x1DA944F: rack::CardinalPluginModel<ModeScaleQuant, ModeScaleQuantWidget>::createModule() (helpers.hpp:57)
==164445==    by 0xB86D0F: CardinalDISTRHO::CardinalUI::uiIdle() (CardinalUI.cpp:568)
==164445==    by 0xBA5A43: plugin_idle (DistrhoUIInternal.hpp:231)
==164445==    by 0xBA5A43: CardinalDISTRHO::runSelfTests() (DistrhoPluginJACK.cpp:901)
==164445==    by 0xA20FB8: main (DistrhoPluginJACK.cpp:1014)
==164445==  Uninitialised value was created by a heap allocation
==164445==    at 0x7734E63: operator new(unsigned long) (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==164445==    by 0x1DA9444: rack::CardinalPluginModel<ModeScaleQuant, ModeScaleQuantWidget>::createModule() (helpers.hpp:57)
==164445==    by 0xB86D0F: CardinalDISTRHO::CardinalUI::uiIdle() (CardinalUI.cpp:568)
==164445==    by 0xBA5A43: plugin_idle (DistrhoUIInternal.hpp:231)
==164445==    by 0xBA5A43: CardinalDISTRHO::runSelfTests() (DistrhoPluginJACK.cpp:901)
==164445==    by 0xA20FB8: main (DistrhoPluginJACK.cpp:1014)
==164445== 


==164445== Conditional jump or move depends on uninitialised value(s)
==164445==    at 0x773C5E3: __strcpy_chk (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==164445==    by 0x1DA7181: strcpy (string_fortified.h:90)
==164445==    by 0x1DA7181: copyHarmonyTypeToActiveHarmonyType (MSQ_data_and_functions.hpp:498)
==164445==    by 0x1DA7181: ModeScaleQuantMusicStructuresInitialize (MSQ_data_and_functions.hpp:509)
==164445==    by 0x1DA7181: ModeScaleQuant::ModeScaleQuant() (ModeScaleQuant.cpp:953)
==164445==    by 0x1DA944F: rack::CardinalPluginModel<ModeScaleQuant, ModeScaleQuantWidget>::createModule() (helpers.hpp:57)
==164445==    by 0xB86D0F: CardinalDISTRHO::CardinalUI::uiIdle() (CardinalUI.cpp:568)
==164445==    by 0xBA5A43: plugin_idle (DistrhoUIInternal.hpp:231)
==164445==    by 0xBA5A43: CardinalDISTRHO::runSelfTests() (DistrhoPluginJACK.cpp:901)
==164445==    by 0xA20FB8: main (DistrhoPluginJACK.cpp:1014)
==164445==  Uninitialised value was created by a heap allocation
==164445==    at 0x7734E63: operator new(unsigned long) (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==164445==    by 0x1DA9444: rack::CardinalPluginModel<ModeScaleQuant, ModeScaleQuantWidget>::createModule() (helpers.hpp:57)
==164445==    by 0xB86D0F: CardinalDISTRHO::CardinalUI::uiIdle() (CardinalUI.cpp:568)
==164445==    by 0xBA5A43: plugin_idle (DistrhoUIInternal.hpp:231)
==164445==    by 0xBA5A43: CardinalDISTRHO::runSelfTests() (DistrhoPluginJACK.cpp:901)
==164445==    by 0xA20FB8: main (DistrhoPluginJACK.cpp:1014)
==164445== 

Signed-off-by: falkTX <falktx@falktx.com>
@falkTX
Copy link
Contributor

falkTX commented Nov 30, 2024

PR updated and fix sent upstream knchaffin/Meander#21

pluginval passes now, so we can merge

@falkTX falkTX merged commit e04647f into main Nov 30, 2024
37 of 40 checks passed
@falkTX falkTX deleted the update/Meander-to-v2.0.34 branch November 30, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants