Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(route/the): Include publisher in the author property #16858

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

dzx-dzx
Copy link
Contributor

@dzx-dzx dzx-dzx commented Sep 22, 2024

Involved Issue / 该 PR 相关 Issue

Close #

Example for the Proposed Route(s) / 路由地址示例

/the

New RSS Route Checklist / 新 RSS 路由检查表

  • New Route / 新的路由
  • Anti-bot or rate limit / 反爬/频率限制
    • If yes, do your code reflect this sign? / 如果有, 是否有对应的措施?
  • Date and time / 日期和时间
    • Parsed / 可以解析
    • Correct time zone / 时区正确
  • New package added / 添加了新的包
  • Puppeteer

Note / 说明

@github-actions github-actions bot added Route Auto: Route Test Complete Auto route test has finished on given PR labels Sep 22, 2024
Copy link
Contributor

Successfully generated as following:

http://localhost:1200/the - Failed ❌
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>FetchError: [GET] &quot;https://the.bi/s/wp-json/wp/v2/posts?_embed=true&amp;per_page=50&amp;page=1&quot;: 403 Forbidden
Route: /the/:filter{.+}?
Full Route: /the
Node Version: v22.9.0
Git Hash: 355f7228

@dzx-dzx
Copy link
Contributor Author

dzx-dzx commented Sep 22, 2024

@nczitzk By the way, have you observed anything other than Stud in the author section when you were testing this route, namely the result of item._embedded.author?

@TonyRL TonyRL merged commit e9a6146 into DIYgod:master Sep 22, 2024
27 checks passed
@nczitzk
Copy link
Contributor

nczitzk commented Sep 23, 2024

@nczitzk By the way, have you observed anything other than Stud in the author section when you were testing this route, namely the result of item._embedded.author?

Thanks for pointing that out. I haven't seen the authors' names anywhere else, and your approach for handling item.author is more fitting. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto: Route Test Complete Auto route test has finished on given PR Route
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants