Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misskey): Handle renotes properly to improve content display #17078

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

SnowAgar25
Copy link
Contributor

Involved Issue / 该 PR 相关 Issue

Close #

Example for the Proposed Route(s) / 路由地址示例

/misskey/users/notes/mttb2ccp@misskey.io

New RSS Route Checklist / 新 RSS 路由检查表

  • New Route / 新的路由
  • Anti-bot or rate limit / 反爬/频率限制
    • If yes, do your code reflect this sign? / 如果有, 是否有对应的措施?
  • Date and time / 日期和时间
    • Parsed / 可以解析
    • Correct time zone / 时区正确
  • New package added / 添加了新的包
  • Puppeteer

Note / 说明

Sorry, I didn't realize (#17068) that this API returns file attachments even without withFiles: true. The real issue affecting the reading experience is that renotes weren't properly handled, resulting in a lot of empty content.
image

@github-actions github-actions bot added the Route label Oct 10, 2024
Copy link
Contributor

Successfully generated as following:

http://localhost:1200/misskey/users/notes/mttb2ccp@misskey.io - Success ✔️
<?xml version="1.0" encoding="UTF-8"?>
<rss xmlns:atom="http://www.w3.org/2005/Atom" version="2.0">
  <channel>
    <title>User timeline for mttb2ccp@misskey.io on misskey.io</title>
    <link>https://misskey.io/@mttb2ccp</link>
    <atom:link href="http://localhost:1200/misskey/users/notes/mttb2ccp@misskey.io" rel="self" type="application/rss+xml"></atom:link>
    <description>User timeline for mttb2ccp@misskey.io on misskey.io - Powered by RSSHub</description>
    <generator>RSSHub</generator>
    <webMaster>contact@rsshub.app (RSSHub)</webMaster>
    <language>en</language>
    <lastBuildDate>Thu, 10 Oct 2024 19:40:08 GMT</lastBuildDate>
    <ttl>5</ttl>
    <item>
      <title>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io): &quot; &lt;p&gt;まぁ、エッチな絵ばかりじゃアレなんでね&lt;br&gt;&lt;br&gt;プリン化って良いですよね:msgk_happy:&lt;/p&gt; &lt;br&gt; &lt;...</title>
      <description>&lt;p&gt;まぁ、エッチな絵ばかりじゃアレなんでね&amp;lt;br&amp;gt;&amp;lt;br&amp;gt;プリン化って良いですよね:msgk_happy:&lt;/p&gt; &lt;br&gt; &lt;img src=&quot;https://media.misskeyusercontent.jp/io/da0fe570-6f0b-42c6-9715-8f94851610dc.png&quot; referrerpolicy=&quot;no-referrer&quot;&gt; </description>
      <link>https://misskey.io/notes/9z70mgbg9zpb0dmg</link>
      <guid isPermaLink="false">https://misskey.io/notes/9z70mgbg9zpb0dmg</guid>
      <pubDate>Thu, 10 Oct 2024 15:26:09 GMT</pubDate>
      <author>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io)</author>
    </item>
    <item>
      <title>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io): &quot; &lt;p&gt;ひとまずこっちに上げてない絵をちまちま上げていこう!&lt;/p&gt; &quot;</title>
      <description>&lt;p&gt;ひとまずこっちに上げてない絵をちまちま上げていこう!&lt;/p&gt; </description>
      <link>https://misskey.io/notes/9z70j5gw9zpb0dgk</link>
      <guid isPermaLink="false">https://misskey.io/notes/9z70j5gw9zpb0dgk</guid>
      <pubDate>Thu, 10 Oct 2024 15:23:35 GMT</pubDate>
      <author>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io)</author>
    </item>
    <item>
      <title>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io): &quot; &lt;p&gt;かえでお姉ちゃん、エッチでいいですよね…&lt;br&gt;&lt;br&gt;#おにまいお絵描き&lt;/p&gt; &lt;br&gt; &lt;img src=&quot;https://...</title>
      <description>&lt;p&gt;かえでお姉ちゃん、エッチでいいですよね…&amp;lt;br&amp;gt;&amp;lt;br&amp;gt;#おにまいお絵描き&lt;/p&gt; &lt;br&gt; &lt;img src=&quot;https://media.misskeyusercontent.jp/io/065c3527-6e1b-4faa-aee1-81fc0db1fc49.png?sensitive=true&quot; referrerpolicy=&quot;no-referrer&quot;&gt; </description>
      <link>https://misskey.io/notes/9z70i5ppvnyd076g</link>
      <guid isPermaLink="false">https://misskey.io/notes/9z70i5ppvnyd076g</guid>
      <pubDate>Thu, 10 Oct 2024 15:22:49 GMT</pubDate>
      <author>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io)</author>
    </item>
    <item>
      <title>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io): &quot; &lt;p&gt;かごのとり氏、元気してるかな…&lt;/p&gt; &quot;</title>
      <description>&lt;p&gt;かごのとり氏、元気してるかな…&lt;/p&gt; </description>
      <link>https://misskey.io/notes/9z70hcp6ml860bss</link>
      <guid isPermaLink="false">https://misskey.io/notes/9z70hcp6ml860bss</guid>
      <pubDate>Thu, 10 Oct 2024 15:22:11 GMT</pubDate>
      <author>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io)</author>
    </item>
    <item>
      <title>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io): &quot; &lt;p&gt;みはり「こ、これ…ちょっと大胆すぎない?」&lt;br&gt;&lt;br&gt;大学の同輩「何言ってるの、似合ってるわよ。...</title>
      <description>&lt;p&gt;みはり「こ、これ…ちょっと大胆すぎない?」&amp;lt;br&amp;gt;&amp;lt;br&amp;gt;大学の同輩「何言ってるの、似合ってるわよ。これならきっとお兄ちゃんもメロメロね❤」&amp;lt;br&amp;gt;&amp;lt;br&amp;gt;#おにまいお絵描き&lt;/p&gt; &lt;br&gt; &lt;img src=&quot;https://media.misskeyusercontent.jp/io/7c98aa8f-c33d-4ce5-9c4e-dd6c760cbb33.png?sensitive=true&quot; referrerpolicy=&quot;no-referrer&quot;&gt; </description>
      <link>https://misskey.io/notes/9z707rwmdls502p9</link>
      <guid isPermaLink="false">https://misskey.io/notes/9z707rwmdls502p9</guid>
      <pubDate>Thu, 10 Oct 2024 15:14:44 GMT</pubDate>
      <author>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io)</author>
    </item>
    <item>
      <title>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io): &quot; &lt;p&gt;ここへの投稿、ドコで止まってたっけかな…&lt;/p&gt; &quot;</title>
      <description>&lt;p&gt;ここへの投稿、ドコで止まってたっけかな…&lt;/p&gt; </description>
      <link>https://misskey.io/notes/9z70342y3rok02a5</link>
      <guid isPermaLink="false">https://misskey.io/notes/9z70342y3rok02a5</guid>
      <pubDate>Thu, 10 Oct 2024 15:11:07 GMT</pubDate>
      <author>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io)</author>
    </item>
    <item>
      <title>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io): &quot; &lt;p&gt;久しぶりに:loli:をみたくなった&lt;br&gt;:mattaku_loli_ha_saikou_daze:&lt;/p&gt; &quot;</title>
      <description>&lt;p&gt;久しぶりに:loli:をみたくなった&amp;lt;br&amp;gt;:mattaku_loli_ha_saikou_daze:&lt;/p&gt; </description>
      <link>https://misskey.io/notes/9z70189uvnyd06fo</link>
      <guid isPermaLink="false">https://misskey.io/notes/9z70189uvnyd06fo</guid>
      <pubDate>Thu, 10 Oct 2024 15:09:39 GMT</pubDate>
      <author>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io)</author>
    </item>
    <item>
      <title>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io): &quot; &lt;p&gt;てすと:test:&lt;/p&gt; &quot;</title>
      <description>&lt;p&gt;てすと:test:&lt;/p&gt; </description>
      <link>https://misskey.io/notes/9z6zzv344e0k017p</link>
      <guid isPermaLink="false">https://misskey.io/notes/9z6zzv344e0k017p</guid>
      <pubDate>Thu, 10 Oct 2024 15:08:35 GMT</pubDate>
      <author>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io)</author>
    </item>
    <item>
      <title>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io): &quot; &lt;p&gt;久しぶりにねこひげ先生見れた!&lt;/p&gt; &quot;</title>
      <description>&lt;p&gt;久しぶりにねこひげ先生見れた!&lt;/p&gt; </description>
      <link>https://misskey.io/notes/9xmg5rih4lqb0dp7</link>
      <guid isPermaLink="false">https://misskey.io/notes/9xmg5rih4lqb0dp7</guid>
      <pubDate>Sun, 01 Sep 2024 01:18:12 GMT</pubDate>
      <author>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io)</author>
    </item>
    <item>
      <title>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io): &quot; &lt;p&gt;:ohayouzyoo__i:&lt;/p&gt; &quot;</title>
      <description>&lt;p&gt;:ohayouzyoo__i:&lt;/p&gt; </description>
      <link>https://misskey.io/notes/9xmg4fz58frz08cb</link>
      <guid isPermaLink="false">https://misskey.io/notes/9xmg4fz58frz08cb</guid>
      <pubDate>Sun, 01 Sep 2024 01:17:11 GMT</pubDate>
      <author>猫乃またたび:verified_blue: (@mttb2ccp@misskey.io)</author>
    </item>
  </channel>
</rss>

@github-actions github-actions bot added the Auto: Route Test Complete Auto route test has finished on given PR label Oct 10, 2024
@TonyRL TonyRL merged commit afb7554 into DIYgod:master Oct 10, 2024
26 of 27 checks passed
@SnowAgar25 SnowAgar25 deleted the misskey/users/notes branch October 10, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto: Route Test Complete Auto route test has finished on given PR Route
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants