Skip to content

Commit

Permalink
adding indirect dependencies to fix warning
Browse files Browse the repository at this point in the history
  • Loading branch information
behrisch committed May 17, 2024
1 parent 95c9279 commit b363b8d
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 8 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ jobs:
if: steps.cache.outputs.cache-hit != 'true'
run: brew install-bundler-gems

# query whether all dependencies are bottled
- run: brew unbottled sumo

- run: brew test-bot --only-cleanup-before

- run: brew test-bot --only-setup
Expand All @@ -45,3 +48,9 @@ jobs:
with:
name: bottles-${{ matrix.os }}
path: '*.bottle.*'

- name: Upload logs as artifact
uses: actions/upload-artifact@main
with:
name: logs-${{ matrix.os }}
path: /Users/runner/Library/Logs/Homebrew/*/*
25 changes: 17 additions & 8 deletions Formula/sumo.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,16 @@ class Sumo < Formula
option "with-examples", "Install docs/examples and docs/tutorial folder"

depends_on "cmake" => :build
depends_on "xerces-c"
depends_on "proj"

Check failure on line 18 in Formula/sumo.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-14)

FormulaAudit/DependencyOrder: dependency "proj" (line 18) should be put before dependency "xerces-c" (line 25)
depends_on "fox"

Check failure on line 19 in Formula/sumo.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-14)

FormulaAudit/DependencyOrder: dependency "fox" (line 19) should be put before dependency "xerces-c" (line 25)
depends_on "python" if build.head? && build.with?("examples")

Check failure on line 20 in Formula/sumo.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-14)

FormulaAudit/DependencyOrder: dependency "python" (line 20) should be put before dependency "xerces-c" (line 25)
depends_on "ffmpeg" => :optional
depends_on "gdal" => :optional
depends_on "gl2ps" => :optional
depends_on "open-scene-graph" => :optional
depends_on "swig" => :optional
# indirect dependencies
depends_on "libice"

Check failure on line 27 in Formula/sumo.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-14)

FormulaAudit/DependencyOrder: dependency "libice" (line 27) should be put before dependency "swig" (line 25)
depends_on "libx11"

Check failure on line 28 in Formula/sumo.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-14)

FormulaAudit/DependencyOrder: dependency "libx11" (line 28) should be put before dependency "swig" (line 25)
depends_on "libxcursor"

Check failure on line 29 in Formula/sumo.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-14)

FormulaAudit/DependencyOrder: dependency "libxcursor" (line 29) should be put before dependency "swig" (line 25)
Expand All @@ -24,14 +33,14 @@ class Sumo < Formula
depends_on "libxi"

Check failure on line 33 in Formula/sumo.rb

View workflow job for this annotation

GitHub Actions / test-bot (macos-14)

FormulaAudit/DependencyOrder: dependency "libxi" (line 33) should be put before dependency "swig" (line 25)
depends_on "libxrandr"
depends_on "libxrender"
depends_on "proj"
depends_on "python" if build.head? && build.with?("examples")
depends_on "xerces-c"
depends_on "ffmpeg" => :optional
depends_on "gdal" => :optional
depends_on "gl2ps" => :optional
depends_on "open-scene-graph" => :optional
depends_on "swig" => :optional
depends_on "fontconfig"
depends_on "freetype"
depends_on "gettext"
depends_on "jpeg-turbo"
depends_on "libpng"
depends_on "libtiff"
depends_on "mesa"
depends_on "mesa-glu"

# workaround due to dependency gdal -> numpy -> openblas -> gcc (originally gfortran)
# (use 'brew deps --tree sumo' to see dependencies of higher levels)
Expand Down

0 comments on commit b363b8d

Please sign in to comment.