Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare types for Result and CheckerResult #1106

Merged
merged 2 commits into from
Jan 29, 2023
Merged

Declare types for Result and CheckerResult #1106

merged 2 commits into from
Jan 29, 2023

Conversation

kiritofeng
Copy link
Member

Fixes a bug where interactive problems will crash upon grading a Java submission that returns IR due to result.proc_output being the empty string '' by default. result.proc_output should now always be a bytestring.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2023

Codecov Report

Base: 81.90% // Head: 81.50% // Decreases project coverage by -0.41% ⚠️

Coverage data is based on head (6541eba) compared to base (2ba1442).
Patch coverage: 87.09% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1106      +/-   ##
==========================================
- Coverage   81.90%   81.50%   -0.41%     
==========================================
  Files         139      139              
  Lines        5008     5013       +5     
==========================================
- Hits         4102     4086      -16     
- Misses        906      927      +21     
Impacted Files Coverage Δ
dmoj/result.py 80.48% <86.20%> (-3.93%) ⬇️
dmoj/executors/base_executor.py 85.85% <100.00%> (-1.02%) ⬇️
dmoj/judge.py 53.33% <100.00%> (ø)
dmoj/utils/communicate.py 88.15% <0.00%> (-5.27%) ⬇️
dmoj/cptbox/isolate.py 48.17% <0.00%> (-3.05%) ⬇️
dmoj/cptbox/compiler_isolate.py 46.80% <0.00%> (-2.13%) ⬇️
dmoj/cptbox/tracer.py 58.30% <0.00%> (-2.13%) ⬇️
dmoj/executors/java_executor.py 84.39% <0.00%> (-0.98%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Xyene Xyene merged commit ee64225 into master Jan 29, 2023
@Xyene Xyene deleted the freaking-yava branch January 29, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants