-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executors: add version checks to self-tests #1109
Conversation
Codecov ReportBase: 81.81% // Head: 84.58% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #1109 +/- ##
==========================================
+ Coverage 81.81% 84.58% +2.76%
==========================================
Files 139 139
Lines 5014 5013 -1
==========================================
+ Hits 4102 4240 +138
+ Misses 912 773 -139
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
80c5f13
to
3d8fc1a
Compare
@@ -1,20 +1,20 @@ | |||
from typing import Optional | |||
|
|||
from .gcc_executor import GCCExecutor | |||
|
|||
|
|||
class Executor(GCCExecutor): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that the C++03 executor is used as a "cpp_executor" of sorts is pretty yucky; we should just make a dedicated one at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Fixes #1108.