Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executors: add version checks to self-tests #1109

Merged
merged 2 commits into from
Feb 3, 2023
Merged

executors: add version checks to self-tests #1109

merged 2 commits into from
Feb 3, 2023

Conversation

kiritofeng
Copy link
Member

Fixes #1108.

@kiritofeng kiritofeng requested a review from Xyene January 31, 2023 07:53
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Base: 81.81% // Head: 84.58% // Increases project coverage by +2.76% 🎉

Coverage data is based on head (3d8fc1a) compared to base (96b2fff).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1109      +/-   ##
==========================================
+ Coverage   81.81%   84.58%   +2.76%     
==========================================
  Files         139      139              
  Lines        5014     5013       -1     
==========================================
+ Hits         4102     4240     +138     
+ Misses        912      773     -139     
Impacted Files Coverage Δ
dmoj/executors/C.py 100.00% <ø> (ø)
dmoj/executors/C11.py 100.00% <ø> (ø)
dmoj/executors/CPP11.py 100.00% <ø> (ø)
dmoj/executors/CPP14.py 100.00% <ø> (ø)
dmoj/executors/CPP17.py 100.00% <ø> (ø)
dmoj/executors/CPP20.py 100.00% <ø> (ø)
dmoj/executors/CLANGX.py 100.00% <100.00%> (ø)
dmoj/executors/CPP03.py 100.00% <100.00%> (ø)
dmoj/executors/PY2.py 100.00% <100.00%> (ø)
dmoj/executors/PY3.py 100.00% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -1,20 +1,20 @@
from typing import Optional

from .gcc_executor import GCCExecutor


class Executor(GCCExecutor):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that the C++03 executor is used as a "cpp_executor" of sorts is pretty yucky; we should just make a dedicated one at some point.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit 6219814 into master Feb 3, 2023
@Xyene Xyene deleted the ver-check-ex branch February 3, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPP03 does not use C++03 dialect
3 participants