Use Decimal in floats checker
#503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiritofeng
force-pushed
the
decimal_checker
branch
2 times, most recently
from
c82270d
to
8e4dbfd
Compare
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
==========================================
+ Coverage 72.8% 72.91% +0.11%
==========================================
Files 126 126
Lines 3938 3947 +9
==========================================
+ Hits 2867 2878 +11
+ Misses 1071 1069 -2
Continue to review full report at Codecov.
|
Xyene
reviewed
Oct 1, 2019
Xyene
reviewed
Oct 1, 2019
kiritofeng
force-pushed
the
decimal_checker
branch
3 times, most recently
from
cedc046
to
a7cb316
Compare
quantum5
reviewed
Oct 1, 2019
dmoj/checkers/floats.py
Outdated
| @@ -27,7 +28,12 @@ def verify_default(process_float, judge_float, epsilon): | |||
| abs(1.0 - process_float / judge_float) <= epsilon) | |||
|
|
|||
|
|
|||
| def check(process_output, judge_output, precision=6, error_mode='default', **kwargs): | |||
| def check(process_output, judge_output, precision=6, high_precision=False, error_mode='default', **kwargs): | |||
There was a problem hiding this comment.
What about precision and other stuff you can control in the decimal context?
Xyene
approved these changes
Oct 1, 2019
kiritofeng
force-pushed
the
decimal_checker
branch
from
a7cb316
to
ad1834a
Compare
kiritofeng
force-pushed
the
decimal_checker
branch
from
ad1834a
to
7b4cda5
Compare
quantum5
added a commit
that referenced
this pull request
Oct 5, 2019
Reverts #503. This is completely broken. The checker will reject anything because `Decimal` constructor does not accept `bytes`. Once that bug is fixed, the inability to control `Decimal`'s precision makes the test case fail, since the numbers do compare equal at default precision. In other words, the only test case worked by accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #456.