Limit Clang/++ compile errors; #487 #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xyene
requested changes
Oct 5, 2019
dmoj/executors/clang_executor.py
Outdated
| @@ -1,9 +1,15 @@ | |||
| from .gcc_executor import GCCExecutor | |||
|
|
|||
|
|
|||
| MAX_ERRORS = 5 | |||
There was a problem hiding this comment.
This should be imported from .gcc_executor.
Codecov Report
@@ Coverage Diff @@
## master #525 +/- ##
==========================================
+ Coverage 72.8% 72.84% +0.03%
==========================================
Files 126 126
Lines 3938 3940 +2
==========================================
+ Hits 2867 2870 +3
+ Misses 1071 1070 -1
Continue to review full report at Codecov.
|
Xyene
reviewed
Oct 5, 2019
dmoj/executors/clang_executor.py
Outdated
| @@ -1,9 +1,13 @@ | |||
| from .gcc_executor import GCCExecutor | |||
| from .gcc_executor import MAX_ERRORS | |||
There was a problem hiding this comment.
This should be imported as part of the first line.
Xyene
approved these changes
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #487