Emulate xterm everywhere #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantum5
approved these changes
Oct 10, 2019
Xyene
force-pushed
the
emulate-xterm-everywhere
branch
from
07648c4
to
60f31c2
Compare
This was referenced Oct 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
==========================================
- Coverage 86.17% 86.16% -0.02%
==========================================
Files 100 100
Lines 2083 2081 -2
==========================================
- Hits 1795 1793 -2
Misses 288 288
Continue to review full report at Codecov.
|
quantum5
reviewed
Oct 14, 2019
| # Emulate the streams of a process connected to a terminal: stdin, stdout, and stderr are all ptys. | ||
| self._master, self._slave = pty.openpty() | ||
| # Some runtimes *cough cough* Swift *cough cough* actually check the environment variables too. | ||
| env = self.get_compile_env() or os.environ.copy() |
There was a problem hiding this comment.
This is actually broken, although you are just copying code. The intention was that get_compile_env could return {}, which is supposed to mean blank environment, except it actually has the same meaning as None now. This is probably not worth changing now.
outloudvi
added a commit
to SchOJ/judge
that referenced
this pull request
Mar 23, 2020
outloudvi
added a commit
to SchOJ/judge
that referenced
this pull request
Mar 23, 2020
outloudvi
added a commit
to SchOJ/judge
that referenced
this pull request
Feb 23, 2021
outloudvi
added a commit
to SchOJ/judge
that referenced
this pull request
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.