Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cptbox: make sys_utimensat emulation more accurate #927

Merged
merged 1 commit into from
Sep 19, 2021
Merged

Conversation

quantum5
Copy link
Member

This handles the case where times is NULL, which is valid and should not
generate EFAULT.

This handles the case where times is NULL, which is valid and should not
generate EFAULT.
@quantum5 quantum5 requested a review from Xyene September 18, 2021 20:53
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2021

Codecov Report

Merging #927 (4af61c7) into master (2ea839a) will decrease coverage by 0.11%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
- Coverage   86.61%   86.49%   -0.12%     
==========================================
  Files         138      138              
  Lines        4670     4673       +3     
==========================================
- Hits         4045     4042       -3     
- Misses        625      631       +6     
Impacted Files Coverage Δ
dmoj/executors/compiled_executor.py 92.76% <61.53%> (+0.14%) ⬆️
dmoj/cptbox/tracer.py 83.27% <0.00%> (-1.82%) ⬇️
dmoj/result.py 89.33% <0.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea839a...4af61c7. Read the comment docs.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xyene Xyene merged commit c456e01 into master Sep 19, 2021
@Xyene Xyene deleted the utimensat-patch branch September 19, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants