Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

judge: fix str/bytes confusion in CompileError #930

Merged
merged 1 commit into from
Sep 19, 2021
Merged

Conversation

quantum5
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2021

Codecov Report

Merging #930 (84bef29) into master (2ea839a) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
+ Coverage   86.61%   86.67%   +0.06%     
==========================================
  Files         138      138              
  Lines        4670     4729      +59     
==========================================
+ Hits         4045     4099      +54     
- Misses        625      630       +5     
Impacted Files Coverage Δ
dmoj/error.py 93.33% <100.00%> (+1.66%) ⬆️
dmoj/judge.py 70.44% <100.00%> (ø)
dmoj/cptbox/tracer.py 83.27% <0.00%> (-1.82%) ⬇️
dmoj/result.py 89.33% <0.00%> (-1.34%) ⬇️
dmoj/utils/module.py 100.00% <0.00%> (ø)
dmoj/utils/error.py 93.33% <0.00%> (+2.42%) ⬆️
dmoj/utils/helper_files.py 95.18% <0.00%> (+3.51%) ⬆️
dmoj/utils/os_ext.py 94.73% <0.00%> (+6.27%) ⬆️
dmoj/utils/load.py 73.91% <0.00%> (+7.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea839a...84bef29. Read the comment docs.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xyene Xyene merged commit 423afd5 into master Sep 19, 2021
@Xyene Xyene deleted the testsuite-bytes branch September 19, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants