executors: improve /usr handling #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some platforms, e.g. arm64, gcc tries to look for non-existent directories under /usr, and complains when forbidden to do so. To fix this, we must allow the entirety of /usr. The only reason we don't allow the entirety of /usr is because on FreeBSD, home directories are located in /usr/home. However, this is easily fixed by using the current logic if /usr/home exists, and otherwise allow everything under /usr.
Codecov Report
@@ Coverage Diff @@
## master #944 +/- ##
==========================================
- Coverage 86.53% 86.41% -0.12%
==========================================
Files 138 138
Lines 4702 4705 +3
==========================================
- Hits 4069 4066 -3
- Misses 633 639 +6
Continue to review full report at Codecov.
|
WallE256
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some platforms, e.g. arm64, gcc tries to look for non-existent
directories under /usr, and complains when forbidden to do so. To fix this,
we must allow the entirety of /usr.
The only reason we don't allow the entirety of /usr is because on FreeBSD,
home directories are located in /usr/home. However, this is easily fixed
by using the current logic if /usr/home exists, and otherwise allow
everything under /usr.