Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove useless functions from citest.py #950

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Conversation

quantum5
Copy link
Member

Most notably, this removes a dependency on distutils.version.LooseVersion, which is deprecated in PEP 632.

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #950 (e2e1452) into master (9704d41) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #950      +/-   ##
==========================================
- Coverage   86.54%   86.42%   -0.13%     
==========================================
  Files         138      138              
  Lines        4736     4736              
==========================================
- Hits         4099     4093       -6     
- Misses        637      643       +6     
Impacted Files Coverage Δ
dmoj/cptbox/tracer.py 83.27% <0.00%> (-1.82%) ⬇️
dmoj/result.py 89.33% <0.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9704d41...e2e1452. Read the comment docs.

Most notably, this removes a dependency on distutils.version.LooseVersion,
which is deprecated in PEP 632.
Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xyene Xyene merged commit 4ffac74 into master Sep 23, 2021
@Xyene Xyene deleted the loose-version-clean branch September 23, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants