Add Node.js to list of languages on README and demo languages #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xyene
reviewed
Jan 7, 2024
README.md
Outdated
| @@ -121,6 +121,7 @@ The judge can also grade in the languages listed below: | |||
| * GAS x86/x64/ARM | |||
| * Haskell | |||
| * INTERCAL | |||
| * JavaScript (Node.js, V8) | |||
There was a problem hiding this comment.
I suppose for consistency with the C++ variants this should say "(Node.js and V8)".
There was a problem hiding this comment.
Changed to say Node.js and V8!
Xyene
reviewed
Jan 22, 2024
| "fields": { | ||
| "key": "NODEJS", | ||
| "name": "JavaScript (Node.js)", | ||
| "short_name": "Node.js", |
There was a problem hiding this comment.
The short name is used on the submission listing. For consistency, it should be all uppercase. If you leave it as null, then key will be used instead (which seems fine in this case).
| "pk": 77, | ||
| "fields": { | ||
| "key": "NODEJS", | ||
| "name": "JavaScript (Node.js)", |
There was a problem hiding this comment.
This naming sounds good to me -- could we also rename V8 to "JavaScript (V8)" for consistency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Related to DMOJ/judge-server#1143:
After enabling support in judge-server for a Node.js-based executor, we need add the language to the demo instance and the documentation
Changes
language_all.json)Testing
Ran
python3 manage.py loaddata language_alland verified the languages were loaded properly in the Admin interface