Skip to content

Commit

Permalink
Merge pull request #3285 from DMPRoadmap/fix-pagniable-links
Browse files Browse the repository at this point in the history
Fix KeywordArgs issue in Paginable concern
  • Loading branch information
benjaminfaure authored Jan 27, 2023
2 parents 1b816d9 + 223a7f9 commit 1348990
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
- Updated sans-serif font used in PDF downloads to Roboto since Google API no longer offers Helvetica
- Fixed discrepencies with default/max per_page values for API and UI pagination
- Updated JS that used to call the TinyMCE `setMode()` function so that it now calls `mode.set()` because the former is now deprecated.
- Fixed an issue with the Rails 6 keyword arguments change that was causing the `paginable_sort_link` to fail

### Changed

Expand Down
2 changes: 1 addition & 1 deletion app/controllers/concerns/paginable.rb
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def sort_link_url(sort_field)
end
base_url = paginable_base_url(query_params[:page])
sort_url = URI(base_url)
sort_url.query = stringify_query_params(query_params)
sort_url.query = stringify_query_params(**query_params)
sort_url.to_s
"#{sort_url}&#{stringify_nonpagination_query_params}"
end
Expand Down

0 comments on commit 1348990

Please sign in to comment.