Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate DOM ids for home page #1064

Closed
jollopre opened this issue Jan 19, 2018 · 1 comment
Closed

Duplicate DOM ids for home page #1064

jollopre opened this issue Jan 19, 2018 · 1 comment
Assignees
@jollopre
Labels
bug

Comments

@jollopre
Copy link
Contributor

Please complete the following fields as applicable:

Expected behaviour:
DOM ids must be unique across the entire page
Actual behaviour:
dom

Steps to reproduce: (for Chrome)

  1. Right click mouse
  2. Click inspect
  3. Go to home page for a non-login in user
@jollopre jollopre self-assigned this Feb 20, 2018
jollopre pushed a commit to DigitalCurationCentre/roadmap that referenced this issue Feb 20, 2018
removed ids for email and password sign_in_form. Refactored JS associ…
7a122d4 
…ated. DMPRoadmap#1064
@jollopre jollopre mentioned this issue Feb 20, 2018
Merged
@stephaniesimms
Copy link

looks good upon inspection. closing issue.

@vyruss vyruss mentioned this issue Apr 20, 2018
Merged
vyruss pushed a commit to DigitalCurationCentre/roadmap that referenced this issue Apr 20, 2018
Fixes DMPRoadmap#1397
72d74e9 
* after_sign_in|up : Check for paths not urls (so that it works on localhost/http)
* remove duplicate IDs from sign_up page by not including it in modal too (related to DMPRoadmap#1064)
xsrust pushed a commit to DigitalCurationCentre/roadmap that referenced this issue Jun 14, 2018
@xsrust
Fixes DMPRoadmap#1397
1bc34e3 
* after_sign_in|up : Check for paths not urls (so that it works on localhost/http)
* remove duplicate IDs from sign_up page by not including it in modal too (related to DMPRoadmap#1064)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jollopre jollopre

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jollopre @stephaniesimms