Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable debug checking for rubocop >=1.45.0 #3291

Closed
pengyin-shan opened this issue Feb 13, 2023 · 2 comments · Fixed by #3292
Closed

Disable debug checking for rubocop >=1.45.0 #3291

pengyin-shan opened this issue Feb 13, 2023 · 2 comments · Fixed by #3292
Assignees
@pengyin-shan
Labels
convention Discuss/agree best practices for all contributors

Comments

@pengyin-shan
Copy link
Contributor

This issue will appear for Rubocop >= 1.45.0. I tested in roadmap >=3.1.0 version.

Noted in portagenetwork#316, rubocop starts to complain about debugging messages after upgrading to 1.45.1:

image

It is because rubocop 1.45.0 (rubocop/rubocop#11517) added debugger detection that will affect most of our rake tasks.

Will push the new rubocop.yml soon.
@pengyin-shan pengyin-shan added the convention Discuss/agree best practices for all contributors label Feb 13, 2023
@pengyin-shan pengyin-shan self-assigned this Feb 13, 2023
@pengyin-shan pengyin-shan mentioned this issue Feb 17, 2023
Merged
@pengyin-shan
Copy link
Contributor Author

Using roadmap suggestions to add exclusions to ONLY lib tasks, instead of disabling all debugger check

@pengyin-shan pengyin-shan linked a pull request Feb 27, 2023 that will close this issue
disable debugger check for rubocop >= 1.45.0 #3292
Merged
@pengyin-shan
Copy link
Contributor Author

Close this ticket for now. The changes are included in #3292 .

@briri briri mentioned this issue Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pengyin-shan pengyin-shan

Labels
convention Discuss/agree best practices for all contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

disable debugger check for rubocop >= 1.45.0 DMPRoadmap/roadmap
1 participant
@pengyin-shan