-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable debugger check for rubocop >= 1.45.0 #3292
Conversation
Thanks for this @pengyin-shan. I actually think that's a useful check for files in the /app and /spec directories. Can you modify this PR so that it only excludes rake tasks? Instead of 'Enabled: false' use:
|
UPDATE on Feb 21, 2023: Github Action was forced to upgrade to node 18. Thus we see the same error as the DMP Assisant bug portagenetwork#319 I'll include |
Finally, all tests passed lol. I added exclusive to rubocop and updated Github actions to use node 16. |
@pengyin-shan you can solve this problem by adding I ran into it recently when upgrading our config to Node 18 |
Unfortunately, I keep getting the @briri how do you feel about this? |
@pengyin-shan was correct, Github Actions would not allow the |
Fixes #3291 and DMP Assisant reported common Github Action error: portagenetwork#319
Changes proposed in this PR:
after DMP Assistant upgrades rubocop to version >= 1.45, the rubocop debugging detection feature ([Discussion] do you think adding a Cop to detect
puts/ap/p/pp
usage in code reasonable ? rubocop/rubocop#11517) is added and rubocop complains all terminal messages, including those ones in rake tasks, like this:Added node version 16 specification to Github Actions
I configure rubocop to disable debugging message checking because we have a lot of necessary messages that need to show in the terminal even if in the production environment.