Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable recaptcha for contact_us form: fixes #501 #1385

Merged
merged 1 commit into from
Apr 16, 2018
Merged

Enable recaptcha for contact_us form: fixes #501 #1385

merged 1 commit into from
Apr 16, 2018

Conversation

vyruss
Copy link
Contributor

@vyruss vyruss commented Apr 16, 2018

Fixes #501 .

Changes proposed in this PR:

  • Enable recaptcha for contact_us form (never worked before :/ )

@vyruss vyruss self-assigned this Apr 16, 2018
@vyruss vyruss requested a review from jollopre April 16, 2018 12:31
jollopre
jollopre approved these changes Apr 16, 2018
View reviewed changes
Copy link
Contributor

@jollopre jollopre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine to me. I think we can get rid of render_new_page protected method since the contact us form used the rails helper for forms only.

@jollopre jollopre merged commit 8856060 into DMPRoadmap:master Apr 16, 2018
@vyruss vyruss deleted the issue501 branch April 16, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jollopre jollopre jollopre approved these changes

Assignees

@vyruss vyruss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyruss @jollopre