Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2941 - Make the display of the phome number in the Plan #3067

Conversation

johnpinto1
Copy link
Contributor

contributor form configurable.

Fix for #2941

Changes:

  • Added a property a boolean valued property config.x.application.display_contributor_phone_number to config/initializers/_dmproadmap.rb.
  • Wrapped the phone number field in
    app/views/contributors/_form.html.erb in a if Rails.configuration.x.application.display_contributor_phone_number statement.

Note: if property not set in config/initializers/_dmproadmap.rb the phone number will not be displayed.

contributor form configurable.

Fix for #2941

Changes:
  - Added a property a boolean valued property config.x.application.display_contributor_phone_number to config/initializers/_dmproadmap.rb.
  - Wrapped the phone number field in
app/views/contributors/_form.html.erb in a if Rails.configuration.x.application.display_contributor_phone_number statement.
Copy link
Contributor

@briri briri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. Thanks @johnpinto1

@briri briri merged commit 7bca37c into development Jan 31, 2022
@briri briri deleted the Bug_2941-make-DMP-contributors-phone-number-requirement-configurable branch January 31, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants