-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Ruby v3.0 #3265
Upgrade to Ruby v3.0 #3265
Conversation
@pengyin-shan I updated the Changelog but am not sure if I did it correctly though. I think the error above is with the Dangerfile itself |
I still need to work on the tests. I have them running locally, but GitHub actions don't seem to be happy. |
Let me merge my previously fixed Danger PR... |
Is your local Danger not happy? It seems the Danger Github action is working fine |
@briri for test related settings, this is currently what we have in Dangerfile:
Do you think we need to change/update anything? |
My local Danger seems ok. The GitHub tests report an issue starting up Rails. They run fine in |
Fixes #3225
selenium-webdriver
andcapybara-webmock
danger
,font-awesome-sass
,webdrivers
@import 'font-awesome-sprockets';
line inapp/assets/stylesheets/application.scss
. Removed that line after referring to the latest font-awesome install/setup guide which no longer includes it..freeze
from Regex and Range constants since those types are already immutabler.nil? ? nil : r.user
, so changed it tor&.user
inapp/models/plan.rb
::
inconfig.log_formatter = ::Logger::Formatter.new
inconfig/environments/production.rb
spec/rails_helper.rb
andspec/spec_helper.rb
spec/support/capybara.rb
helper to work with the latest version of Capybara and use its built in headless Chrome driver