Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ruby 3.0.5 #3266

Merged
merged 19 commits into from
Mar 9, 2023
Merged

Upgrade to Ruby 3.0.5 #3266

merged 19 commits into from
Mar 9, 2023

Conversation

briri
Copy link
Contributor

@briri briri commented Dec 13, 2022

Fixes #3225

  • Upgrade to Ruby version 3.0.5
  • Bumped all Github actions to use ruby 3.0
  • Cleaned up Gemfile by:
    • removing gems that were already commented out
    • removed selenium-webdriver and capybara-webmock
    • removing version restrictions on: danger, font-awesome-sass, webdrivers
  • Ran into issue with @import 'font-awesome-sprockets'; line in app/assets/stylesheets/application.scss. Removed that line after referring to the latest font-awesome install/setup guide which no longer includes it.
  • Updated places that were incorrectly using keyword args. See this article for an overview
  • Removed .freeze from Regex and Range constants since those types are already immutable
  • Fixed Rubocop complaint about redundancy of r.nil? ? nil : r.user, so changed it to r&.user in app/models/plan.rb
  • Fixed Rubocop complaint about redundant :: in config.log_formatter = ::Logger::Formatter.new in config/environments/production.rb
  • Froze deprecator constants that were Strings
  • Cleaned up spec/rails_helper.rb and spec/spec_helper.rb
  • Simplified the spec/support/capybara.rb helper to work with the latest version of Capybara and use its built in headless Chrome driver

Copy link
Contributor

@benjaminfaure benjaminfaure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR includes an upgrade to FontAwesome (from 5 to 6). Was there any problem with the icons ?
With the upgrade from 4 to 5, a lot of icons had to be renamed

@briri
Copy link
Contributor Author

briri commented Dec 14, 2022

I will have to check, the column sorts looked ok. I will do a more thorough check though.

Copy link
Contributor

@pengyin-shan pengyin-shan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@briri the CHANGELOG looks good to me. It described the content of the PR very well. After your PR is merged into the development branch, whoever wants to submit another PR will attach more stuff after your updates.

Then when the v4.1.0 got released, the release can just copy and paste our CHANGELOG to release notes.

@briri
Copy link
Contributor Author

briri commented Dec 14, 2022

great! thanks for reviewing it @pengyin-shan

@briri briri changed the title Upgrade to Ruby 3.0.5 Upgrade to Ruby 3.0.5 - WIP Jan 23, 2023
@briri briri changed the title Upgrade to Ruby 3.0.5 - WIP Upgrade to Ruby 3.0.5 Feb 13, 2023
@briri briri merged commit bae1175 into development Mar 9, 2023
@briri briri deleted the ruby3.0 branch March 9, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants