-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Ruby 3.0.5 #3266
Upgrade to Ruby 3.0.5 #3266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR includes an upgrade to FontAwesome (from 5 to 6). Was there any problem with the icons ?
With the upgrade from 4 to 5, a lot of icons had to be renamed
I will have to check, the column sorts looked ok. I will do a more thorough check though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@briri the CHANGELOG looks good to me. It described the content of the PR very well. After your PR is merged into the development branch, whoever wants to submit another PR will attach more stuff after your updates.
Then when the v4.1.0 got released, the release can just copy and paste our CHANGELOG to release notes.
great! thanks for reviewing it @pengyin-shan |
Fixes #3225
selenium-webdriver
andcapybara-webmock
danger
,font-awesome-sass
,webdrivers
@import 'font-awesome-sprockets';
line inapp/assets/stylesheets/application.scss
. Removed that line after referring to the latest font-awesome install/setup guide which no longer includes it..freeze
from Regex and Range constants since those types are already immutabler.nil? ? nil : r.user
, so changed it tor&.user
inapp/models/plan.rb
::
inconfig.log_formatter = ::Logger::Formatter.new
inconfig/environments/production.rb
spec/rails_helper.rb
andspec/spec_helper.rb
spec/support/capybara.rb
helper to work with the latest version of Capybara and use its built in headless Chrome driver