Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo, probably introduced by v1 code #3325

Merged
merged 3 commits into from
Oct 16, 2023
Merged

fix typo, probably introduced by v1 code #3325

merged 3 commits into from
Oct 16, 2023

Conversation

nicolasfranck
Copy link
Contributor

fix typo, probably introduced by v1 code

@per_page attribute does not exists here, so returns an internal server error containing

[6689aad6-1f63-4bfc-aae0-3f331d464dc1] NoMethodError (undefined method `>' for nil:NilClass):
[6689aad6-1f63-4bfc-aae0-3f331d464dc1]   
[6689aad6-1f63-4bfc-aae0-3f331d464dc1] app/controllers/api/v0/plans_controller.rb:104:in `index'

@nicolasfranck nicolasfranck mentioned this pull request Jul 13, 2023
Open
@nicolasfranck nicolasfranck mentioned this pull request Sep 4, 2023
Closed
nicolasfranck added a commit to DMPbelgium/roadmap that referenced this pull request Sep 21, 2023
@nicolasfranck
prematurely fix bug as fixed by DMPRoadmap/roadmap#3325
795a2de
@dstuckey-uoe dstuckey-uoe changed the base branch from main to development October 2, 2023 15:53
@martaribeiro martaribeiro merged commit 83ad549 into DMPRoadmap:development Oct 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasfranck @martaribeiro