Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backplane options for SunIllumination and SurfaceObliqueDetectorResolution to phocube #5467

Closed
kledmundson opened this issue Apr 17, 2024 · 2 comments
Closed

Add backplane options for SunIllumination and SurfaceObliqueDetectorResolution to phocube #5467

kledmundson opened this issue Apr 17, 2024 · 2 comments
Labels
enhancement New feature or request inactive Issue that has been inactive for at least 6 months

Comments

@kledmundson
Copy link
Contributor

kledmundson commented Apr 17, 2024 •
edited
Loading

Description

The SunIlluminationMask (or shadow mask), is particularly useful for small irregular bodies (e.g. comets, asteroids) where terrain may be occluded from solar illumination at the surface intersection point at a given pixel. This information cannot be provided solely by incidence or local incidence angles as occlusions occur due to foreground terrain, such as lobes in comets, at much larger distances than the proximity of the initial surface point of intersection.

A pixel in the SunIlluminationMask backplane is either 0 (occluded) or 1 (illuminated), as determined by ray tracing. A look direction from the sun is computed to the spacecraft (camera) surface intercept pixel location. If the solar intercept point is not identical to that seen from the spacecraft/camera perspective, it is occluded (shadowed). For tesselated plate shape models, often used to represent the shape of irregular bodies, both camera and solar surface intercept points must occur on the same triangle at approximately the same location.

The existing Oblique Detector Resolution backplane is computed using the local emission angle from the shape model. The Surface Oblique Detector Resolution backplane is computed using the emission angle as determined from the ellipsoid, producing a smoother data plane.

The University of Arizona OSIRIS-REx Image Processing group have added these additional backplanes to their version of phocube.

Example

OSIRIS-REx MapCam image (left), corresponding SunIlluminationMask backplane (center), and Surface Oblique Detector Resolution backplane (right).

phocubeNewBackPlanes
@kledmundson kledmundson added the enhancement New feature or request label Apr 17, 2024
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Apr 24, 2024
@kledmundson
Added phocube options to create SUNILLUMINATIONMASK and SURFACEOBLIQU…
28907f4 
…EDETECTORRESOLUTION backplanes. Added gtests for these options. Updated documentation and added an example. Addresses DOI-USGS#5467.
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Apr 24, 2024
@kledmundson
Removed unwanted phocube test Makefile, input, and truth data obtaine…
e80c40e 
…d via cherry-pick from U. of Arizona codebase. Addresses DOI-USGS#5467.
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Apr 24, 2024
@kledmundson
Minor updates to phocube app, documentation, and gtests. Addresses DO…
9d1749d 
…I-USGS#5467.
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Apr 25, 2024
@kledmundson
Modified .gitignore to enable upload of phocube test cube; updated CH…
7caabec 
…ANGELOG.md for phocube backplane additions. Addresses DOI-USGS#5467.
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Apr 26, 2024
@kledmundson
Minor documentation update and removal of unneeded include file. Addr…
d72e4c5 
…esses DOI-USGS#5467.
@kledmundson kledmundson mentioned this issue Apr 26, 2024
Merged
12 tasks
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Jul 23, 2024
@kledmundson
Per reviewer comments: 1) replaced cam->DetectorResolution() with cam…
3cbc0a6 
…->ObliqueDetectorResolution(false), where "false" refers to the useLocal parameter; and 2) fixed typo in phocube.xml. Addresses DOI-USGS#5467.
kledmundson added a commit to kledmundson/ISIS3 that referenced this issue Jul 24, 2024
@kledmundson
Updated gtest FunctionalTestPhocubeSurfaceObliqueDetectorResolution. …
f151ce6 
…Addresses DOI-USGS#5467.
acpaquette pushed a commit that referenced this issue Jul 26, 2024
@kledmundson @KrisBecker
New backplane options for SunIllumination and SurfaceObliqueDetectorR…
87b7704 
…esolution have been added to phocube (#5488)

* Added sun illumination mask backplane.

phocube
 * Added robust implementation to determine solar illumination on body considering terrain occlusion
* Added app test for this option
* Updated documentation describing this new feature

* Add SurfaceObliqueDetectorResoluton plane

* phocube - This new plane is in addition to the existing ObliqueDetectorResolution. The difference is ObliqueDetectorResolution uses the local (shape model) emission angle and SurfaceObliqueDetectorResolution uses the emission angle calculated from the ellipsoid.

Signed-off-by: Kris J. Becker <kbecker@orex.lpl.arizona.edu>

* Added phocube options to create SUNILLUMINATIONMASK and SURFACEOBLIQUEDETECTORRESOLUTION backplanes. Added gtests for these options. Updated documentation and added an example. Addresses #5467.

* Removed unwanted phocube test Makefile, input, and truth data obtained via cherry-pick from U. of Arizona codebase. Addresses #5467.

* Minor updates to phocube app, documentation, and gtests. Addresses #5467.

* Modified .gitignore to enable upload of phocube test cube; updated CHANGELOG.md for phocube backplane additions. Addresses #5467.

* Minor documentation update and removal of unneeded include file. Addresses #5467.

* Per reviewer comments: 1) replaced cam->DetectorResolution() with cam->ObliqueDetectorResolution(false), where "false" refers to the useLocal parameter; and 2) fixed typo in phocube.xml. Addresses #5467.

* Second try on addressing reviewer comment on "cam->ObliqueDetectorResolution(false)" in phocube.cpp. Addresses

* Updated gtest FunctionalTestPhocubeSurfaceObliqueDetectorResolution. Addresses #5467.

---------

Signed-off-by: Kris J. Becker <kbecker@orex.lpl.arizona.edu>
Co-authored-by: Kris J. Becker <kbecker@orex.lpl.arizona.edu>
@github-actions GitHub Actions
Copy link

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

If you want to participate in our support prioritization meetings or be notified when support sprints are happening, you can sign up the support sprint notification emails here.

Read more about our support processs here

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label Oct 15, 2024
@kledmundson
Copy link
Contributor Author

Closed via #5488.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request inactive Issue that has been inactive for at least 6 months
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kledmundson