Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect handling of Radius in jigsaw gui and in bundleout.txt file when running a rectangular (XYZ) bundle adjustment. #5642

Closed
kledmundson opened this issue Oct 21, 2024 · 1 comment
Closed

Incorrect handling of Radius in jigsaw gui and in bundleout.txt file when running a rectangular (XYZ) bundle adjustment. #5642

kledmundson opened this issue Oct 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@kledmundson
Copy link
Contributor

ISIS version(s) affected: x.y.z
dev

Description

  1. In the jigsaw gui, if the CONTROL_POINT_COORDINATE_TYPE_BUNDLE under "Control Point Parameters" is RECTANGULAR, then the RADIUS checkbox under "Solve Options" should be excluded.

  2. With error propagation turned on in a rectangular (XYZ) solution, uncertainty statistics for Point Z coordinates are not reported in the "POINTS UNCERTAINTY SUMMARY" section. Instead, the RMS, MIN, and MAX of RADIUS coordinates is reported as "N/A."

How to reproduce

Possible Solution

Additional context
@kledmundson kledmundson added the bug Something isn't working label Oct 21, 2024
kledmundson added a commit to UA-LPL/ISIS3 that referenced this issue Oct 21, 2024
@kledmundson
Bug fixes to address incorrect handling of RADIUS in the jigsaw GUI a…
9b3d5c1 
…nd in the bundleout.txt file when performing a rectangular (XYZ) bundle adjustment, originally implemented in UofA OSIRIS-REx code on 2019-07-30. Addresses DOI-USGS#5642.

* The RADIUS checkbox in the GUI is excluded when a RECTANGULAR solution is selected.

* In the bundleout.txt file, for rectangular solutions, 1) RADIUS is set to N/A in the SOLVE OPTIONS section; and 2) the POINTS UNCERTAINTY SECTION was fixed to properly display adjusted point uncertainty statistics with Error Propagation turned on.

* Spacing for point labels was cleaned up in the INPUT: GLOBAL IMAGE PARAMETER UNCERTAINTIES section.

* Finally, a slight modification was added to the FunctionalTestJigsawBundleXYZ ctest to verify that RADIUS is N/A in a RECTANGULAR solution.
@kledmundson kledmundson mentioned this issue Oct 22, 2024
Merged
12 tasks
AustinSanders pushed a commit that referenced this issue Oct 25, 2024
@kledmundson
Bug fixes to address incorrect handling of RADIUS in the jigsaw GUI a…
e9e973a 
…nd in the bundleout.txt file when performing a rectangular (XYZ) bundle adjustment, originally implemented in UofA OSIRIS-REx code on 2019-07-30. Addresses #5642. (#5643)

* The RADIUS checkbox in the GUI is excluded when a RECTANGULAR solution is selected.

* In the bundleout.txt file, for rectangular solutions, 1) RADIUS is set to N/A in the SOLVE OPTIONS section; and 2) the POINTS UNCERTAINTY SECTION was fixed to properly display adjusted point uncertainty statistics with Error Propagation turned on.

* Spacing for point labels was cleaned up in the INPUT: GLOBAL IMAGE PARAMETER UNCERTAINTIES section.

* Finally, a slight modification was added to the FunctionalTestJigsawBundleXYZ ctest to verify that RADIUS is N/A in a RECTANGULAR solution.
@AustinSanders
Copy link
Contributor

Closed via #5643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AustinSanders @kledmundson