Added I/F calibration step to hyb2onccal #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade libtiff to 4.0.10 (DOI-USGS#636) * Switch libtiff to 4.0.9 or higher to remove geotiff conflict
…o give it the correct dimensions.
…s instead of an array of ints.
…cted images and screwing things up. Fixed it.
Fixed warning in Pixel unit tests
* Moved ISIS3 conda-build recipe from ISIS3_deps repository * Un-pinned non-astro build numbers * Removing build numbers from external libraries in the environment and meta.yeml files * Final merging
DOI-USGS#5187 (DOI-USGS#659) * Removed bolding of some text to decrease distraction. * Fixed some typos. * Reworded documentation.
…l files to compile remotely.
…esolved symbol errors (CMakeLists.txt) and to fix some bugs in hyb2onc2isis involved with turning it into a callable function.
* Updates README with Discourse * Update README.md * Update README.md
…e, QString outputCubeFileName, CubeAttributeOutput att, QString target)
…cumentation. The documentation will need to be corrected before this is merged into dev.
|
Looks good. |
kajw1024
approved these changes
Mar 4, 2019
acpaquette
pushed a commit
to acpaquette/ISIS3
that referenced
this pull request
Apr 6, 2021
* Added AlphaCube group to outputlabel in the event the image is cropped. * Fix libtiff dependency (DOI-USGS#636) (DOI-USGS#644) * Upgrade libtiff to 4.0.10 (DOI-USGS#636) * Switch libtiff to 4.0.9 or higher to remove geotiff conflict * Moved ISIS3 conda-build recipe from ISIS3_deps repository (DOI-USGS#650) * Fixed warning in Pixel unit tests * Made a tweak to the dimensions of the alpha cube for cropped images to give it the correct dimensions. * Changed the transform function so it could process an array of doubles instead of an array of ints. * Smear correction was being incorrectly applied to onboard smear corrected images and screwing things up. Fixed it. * Added gtest capability to hyb2onc2isis * Removing build numbers from external libraries (DOI-USGS#660) * Moved ISIS3 conda-build recipe from ISIS3_deps repository * Un-pinned non-astro build numbers * Removing build numbers from external libraries in the environment and meta.yeml files * Final merging * Added pixel type attribute to the output image of program shadow. Fixes DOI-USGS#5187 (DOI-USGS#659) * Removed bolding of some text to decrease distraction. * Fixed some typos. * Reworded documentation. * Added section for Environment and PreferemcesSetup in the Getting Started Section. (DOI-USGS#663) * Updated .gitmodules to use https rather than ssh (DOI-USGS#673) * Added build type release to conda recipe (DOI-USGS#676) * Modified isis/tests/CMakeLists.txt as well as hyb2onc2isis to fix unresolved symbol errors (CMakeLists.txt) and to fix some bugs in hyb2onc2isis involved with turning it into a callable function. * Added w1 test to hyb2onc2isisTests.cpp * Modified hyb2onccal to be a callable function. * Updates README with Discourse (DOI-USGS#690) * Updates README with Discourse * Update README.md * Update README.md * Changed the Pvl label output for Pvl hyb2onc2isis(QString fitsFileName, QString outputCubeFileName, CubeAttributeOutput att, QString target) * Added Newton-Rapheson method to Hyb2OncCalUtils.h to solve the linearity equation. * Final push of hayabusa2 changes made to the ingestion/calibration applications. * Added I/F calibration step. Cleaned up code base and worked on the documentation. The documentation will need to be corrected before this is merged into dev. * Fixed a missing </li> tag in hyb2onccal.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: