Blob Refactor #4348
Merged
Blob Refactor #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Converted Imagepolygon to no longer be a subclass of blob * Updated Imagepolygon with constructor chaining * Fixed error message
* Initial refactor of OriginalLabel class * Addressed PR feedback * Fixed error message Co-authored-by: Jesse Mapel <jmapel@usgs.gov>
* Ported Table test to gtest * Table refactor * Fixed merge issue * Fixed merge issues
* Initial refactor of OriginalLabel class * Addressed PR feedback * Fixed error message * Remove blob inheritance from originalxmllabel * Removed commented / old code * Added byte order specification
* Adds History object tests * Updated blob tests to use a non-pointer variable
* Removed blob inheritance from stretchblob * Addressed feedback + working read/write * Updated cubestretch with the stretch blob functionality * Removed stretchBlob and updated cubestretch/cube with read write functionality * Replaced readStretchBlob with readCubeStretch * Fixed segfault * Removed debug print statements * Added check for existence of OriginalLabel before attempting to propagate * Addressed PR feedback Co-authored-by: Adam Paquette <acpaquette@usgs.gov>
* Converted StringBlob * Removed StretchBlob class * Changed Blob setData to copy * Added csminit change and docs * Removed old memcopy
* Implemented old history functionality * Removed old history unit test * Fixed original label reading
* Fixed test failures * More clean-up * Fixed marci2isis test
* Redid Blob writing * Added docs
AustinSanders
previously approved these changes
Mar 8, 2021
acpaquette
previously approved these changes
Mar 8, 2021
jessemapel
commented
Mar 8, 2021
jessemapel
dismissed stale reviews from acpaquette and AustinSanders
via
67e8c9b
|
CI is good, the new app test failures are all expected and we have test data ready to check in. @acpaquette @AustinSanders just need a re-approval on this to merge. |
AustinSanders
approved these changes
Mar 9, 2021
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completes RFC 6, the Blob refactor so that Classes uses Blobs to serialize themselves, but don't inherit from Blob. This is API breaking and several classes were removed because their functionality independent of Blob was too small. This also adds new gtests for several of the Blob classes.
There are several failing app tests, but they are due to slightly different sizes in the Blobs because of how the storage method was cleaned up. Updated test data is ready to be checked in one this is merged.
Related Issue
#4082
Motivation and Context
This makes it much easier to serial new objects to a cube because they do not need to inherit an entire new class with members, particularly for classes that already have a parent class. This also reduces the code base by a good amount and reduces the amount of functionality that must be tested on many classes.
How Has This Been Tested?
All Blob classes were tested by hand and with automated tests. In particular, the CubeStretch/StretchBlob changes were hand tested and verified.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: