Tweaks to improve CSM Camera functionality #4543
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed CSMCamera to save off the look vector in setImage when it doesn't intersect the body. This matches the ISIS camera model functionality and will be important for oblique observations with CSM models.
Also changed Camera::LocalPhotometricAngles to use the Camera API to get the body-fixed sensor location instead of directly accessing the body rotation. This allows for the computation of local photometric angles with CSM camera models.
Related Issue
#4410 and general CSM support
Motivation and Context
This improves CSM support and will help for potential grounded observations in the future.
How Has This Been Tested?
I tested the local photometric angles in phocube and they worked as expected. The CSMCamera saving the look vector fix is tested by a new unit test.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: