Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to improve CSM Camera functionality #4543

Merged
merged 2 commits into from
Jun 28, 2021

Conversation

jessemapel
Copy link
Contributor

Description

Changed CSMCamera to save off the look vector in setImage when it doesn't intersect the body. This matches the ISIS camera model functionality and will be important for oblique observations with CSM models.

Also changed Camera::LocalPhotometricAngles to use the Camera API to get the body-fixed sensor location instead of directly accessing the body rotation. This allows for the computation of local photometric angles with CSM camera models.

Related Issue

#4410 and general CSM support

Motivation and Context

This improves CSM support and will help for potential grounded observations in the future.

How Has This Been Tested?

I tested the local photometric angles in phocube and they worked as expected. The CSMCamera saving the look vector fix is tested by a new unit test.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@jessemapel jessemapel merged commit 0521e1c into DOI-USGS:csmbundle Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant