Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates KaguyaTC ingest for SPSupport data #4688

Merged
merged 6 commits into from
Nov 16, 2021
Merged

Conversation

jlaura
Copy link
Collaborator

@jlaura jlaura commented Nov 14, 2021

Description

This PR adds support for KaguyaTC Sp Support data by adding the appropriate DATA_SET_ID to the id lookup.

Related Issue

#4668

Motivation and Context

The SP Support data ingest without issue if one manually alters the label to mock a stereo (S) or monoscopic (W) observation. The ingest is identical, except that the DATA_SET_ID lookup does not include the proper SP data id.

How Has This Been Tested?

A GTest has been added using clipped SP Support data (thanks @AustinSanders for the clipping notebooks!). I am on BigSur and have not been able to build locally, so I am depending upon the CI to catch any potential bugs I introduced. Working on getting a build on the new laptop like the rest of us!

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@jessemapel jessemapel merged commit 2c40e08 into DOI-USGS:dev Nov 16, 2021
@jlaura jlaura deleted the 4668 branch November 16, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants