Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed qview crashing when reading pixel value #4869

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

jessemapel
Copy link
Contributor

Description

Fixed a new function in the qview track tool sometimes not returning.

Related Issue

Fixes #4818

Motivation and Context

The function would return void and then that would cause a seg fault when we attempted to use that value.

How Has This Been Tested?

I tested on both Mac and Ubuntu in grayscale and color modes. It no longer crashes.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@jessemapel jessemapel added the bug Something isn't working label Mar 20, 2022
@jessemapel jessemapel requested a review from acpaquette March 20, 2022 17:19
@jessemapel jessemapel merged commit 5b23dce into DOI-USGS:dev Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qview - Seg Faults under isis7.0.0-RC1
2 participants