Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lrowaccal for testability and add a radiance units label to the output cube #4940

Merged
merged 27 commits into from
May 11, 2022
Merged

Refactor lrowaccal for testability and add a radiance units label to the output cube #4940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
80aa14b
Add radiance units label in lrowaccal output cube
cordellmichaud Mar 23, 2022
35151be
Merge pull request #18 from lrocdev/dev-lrowaccal-unitsfix
victoronline Apr 12, 2022
89b7a8b
Refactor lrowaccal app to be callable for testing and add radiance un…
cordellmichaud Apr 26, 2022
2096549
Update formatting and NULL initialization
cordellmichaud Apr 26, 2022
fc41975
Add NULL assignments after deletions
cordellmichaud Apr 26, 2022
ffbaf33
Merge branch 'USGS-Astrogeology:dev' into dev
victoronline Apr 29, 2022
f3cb0f1
Add CubeAttributeOutput to output cube initialization
cordellmichaud Apr 29, 2022
dc5a5c6
Add functional test for lrowaccal units label addition and accompanyi…
cordellmichaud Apr 29, 2022
b91bd36
Merge branch 'USGS-Astrogeology:dev' into dev-lrowaccal-unitsfix-tests
cordellmichaud Apr 29, 2022
1a21e49
Merge branch 'USGS-Astrogeology:dev' into dev-lrowaccal-unitsfix-tests
cordellmichaud May 2, 2022
58eaa15
Refactor lrowaccal to remove global variables and convert helper func…
cordellmichaud May 3, 2022
f930473
Merge branch 'USGS-Astrogeology:dev' into dev-lrowaccal-unitsfix-tests
cordellmichaud May 3, 2022
85584d2
Update history section of lrowaccal XML file with refactoring and out…
cordellmichaud May 3, 2022
32a8a8f
Merge upstream changes into lrowaccal feature branch
cordellmichaud May 3, 2022
141db26
Merge branch 'USGS-Astrogeology:dev' into dev
cordellmichaud May 3, 2022
aa9f024
Remove old lrowaccal Makefile tests
cordellmichaud May 3, 2022
fbb64e4
Merge branch 'dev' into dev-lrowaccal-unitsfix-tests
cordellmichaud May 3, 2022
5692de5
Add lrowaccal functional test to ensure that the radiance units label…
cordellmichaud May 4, 2022
3227775
Add Cordell Michaud to the .zenodo.json document
cordellmichaud May 4, 2022
954e59f
Add lrowaccal changes to CHANGELOG.md
cordellmichaud May 4, 2022
cf9f055
Clean up lrowaccal includes and leftover comment
cordellmichaud May 4, 2022
676efb9
Re-add lrowaccal Makefile tests
cordellmichaud May 4, 2022
d91aa06
Re-add disclaimer to top of lrowaccal's main.cpp file
cordellmichaud May 4, 2022
aaf2380
Add input attributes retrieval to lrowaccal.cpp
cordellmichaud May 4, 2022
4ca4f7a
Fix lrowaccal functional test error messages and add PVl group and ex…
cordellmichaud May 5, 2022
2e619f6
Move lrowaccal units change message to Changed sub-header in CHANGELO…
cordellmichaud May 5, 2022
48fd1fb
Simplify lrowaccal functional test assertions
cordellmichaud May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .zenodo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,10 @@
"affiliation": "University of California, Los Angeles",
"name": "Mehlman, Bob"
},
{
"affiliation": "Arizona State University",
"name": "Michaud, Cordell"
},
{
"name": "Milazzo, Moses"
},
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ release.
- Added a new application, framestitch, for stitching even and odd push frame images back together prior to processing in other applications. [4924](https://github.com/USGS-Astrogeology/ISIS3/issues/4924)

### Changed
- Updated the LRO calibration application Lrowaccal to add a units label to the RadiometricType keyword of the Radiometry group in the output cube label if the RadiometricType parameter is Radiance. No functionality is changed if the RadiometricType parameter is IOF. Lrowaccal has also been refactored to be callable for testing purposes. Issue: [#4939](https://github.com/USGS-Astrogeology/ISIS3/issues/4939), PR: [#4940](https://github.com/USGS-Astrogeology/ISIS3/pull/4940)

### Added
- Improved functionality of msi2isis and MsiCamera model to support new Eros dataset, including support for Gaskell's SUMSPICE files that adjust timing, pointing and spacecraft position ephemeris. [#4886](https://github.com/USGS-Astrogeology/ISIS3/issues/4886)
Expand Down
Loading