Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify framestitch to preserve tables and kernels #4972

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

jessemapel
Copy link
Contributor

Description

Changed framestitch to keep the kernels group and tables so that we can use them in ALE to generate an ISD.

Related Issue

Related to #4945

Motivation and Context

Currently, the stitched cube cannot be used in ALE by itself to generate an ISD. You have to use an unstitched cube to do that, but with the addition of line trimming we now need to work with the framestitch output.

How Has This Been Tested?

Tested locally on a LRO WAC image and re-ran all framestitch tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@oleg-alexandrov
Copy link
Contributor

oleg-alexandrov commented Jun 10, 2022

Was it attempted to see if ale and csm would then be able to create and use the isd made this way?

@jessemapel
Copy link
Contributor Author

Yes I was able to successfully generate an ISD using the kernels from the stitched cube and it worked with the changes in DOI-USGS/usgscsm#397 So I think both of these are ready to go once CI passes on this PR.

@jessemapel
Copy link
Contributor Author

CI is good. Only failure is known in dev right now:

The following tests FAILED:
	897 - TestKernelDb.TestKernelsSmithOffset (Failed)
Errors while running CTest

@jessemapel jessemapel merged commit 95b1fcf into DOI-USGS:dev Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants