Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hist blob fix #4995

Merged
merged 4 commits into from
Dec 1, 2022
Merged

hist blob fix #4995

merged 4 commits into from
Dec 1, 2022

Conversation

gsn9
Copy link
Contributor

@gsn9 gsn9 commented Jul 14, 2022

There was an error with the history blobs on a cube, if the keyword from in the blob contained a , the application would throw an error.

Description

Changed the PvlKeyword parser to handle keywords that contain a ,.

Related Issue

Solves #4337

Motivation and Context

How Has This Been Tested?

Tested locally to verify that running an application like cathist on a cube that has a key with 1,2,3 in its value doesn't error out and the history is correctly displayed.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@gsn9 gsn9 requested review from Kelvinrr and jessemapel July 14, 2022 21:10
@gsn9 gsn9 requested a review from Kelvinrr July 14, 2022 22:13
@gsn9 gsn9 requested a review from Kelvinrr July 14, 2022 23:09
@Kelvinrr
Copy link
Collaborator

If we can get a receipt showing local tests are reasonably clean, we can merge this.

@amystamile-usgs
Copy link
Contributor

Seems like the regex (,*[0-9]?)? was not properly matching with the first comma in the keyword. I updated to only look at the first character for a comma by using ^,

Screen Shot 2022-11-30 at 12 58 09 PM

@amystamile-usgs amystamile-usgs removed the request for review from jessemapel November 30, 2022 20:03
@amystamile-usgs
Copy link
Contributor

Jenkins tests look good https://jenkins.prod-asc.chs.usgs.gov:8443/job/ISIS/view/change-requests/job/PR-4995/. This is ready for a re-review.

@amystamile-usgs amystamile-usgs requested review from Kelvinrr and removed request for Kelvinrr December 1, 2022 18:41
@amystamile-usgs amystamile-usgs merged commit bb6d639 into DOI-USGS:dev Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants