-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hist blob fix #4995
Merged
Merged
hist blob fix #4995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kelvinrr
requested changes
Jul 14, 2022
Kelvinrr
reviewed
Jul 14, 2022
If we can get a receipt showing local tests are reasonably clean, we can merge this. |
amystamile-usgs
force-pushed
the
new_hist_blob_fix
branch
from
November 30, 2022 17:56
856172e
to
a15f1a9
Compare
Jenkins tests look good https://jenkins.prod-asc.chs.usgs.gov:8443/job/ISIS/view/change-requests/job/PR-4995/. This is ready for a re-review. |
AustinSanders
approved these changes
Dec 1, 2022
amystamile-usgs
requested review from
Kelvinrr
and removed request for
Kelvinrr
December 1, 2022 18:41
Kelvinrr
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error with the history blobs on a cube, if the keyword
from
in the blob contained a,
the application would throw an error.Description
Changed the PvlKeyword parser to handle keywords that contain a
,
.Related Issue
Solves #4337
Motivation and Context
How Has This Been Tested?
Tested locally to verify that running an application like cathist on a cube that has a key with
1,2,3
in its value doesn't error out and the history is correctly displayed.Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: