isisdataeval Updates, fixes and additional documentation

[KrisBecker]

Apologies I missed the merge of #5111 with a few, but perhaps helpful, updates.

isisdata_mockup.py - Added —tojson and —hasher parameters to improve utility

make_isisdata_mockup.sh - Fixed path to test data and added new parameters to the isisdata_mockup.py introduced in this PR

README.md - improved/clarified/updated documentation

Description

Related Issue

#5111

How Has This Been Validated?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Documentation change (update to the documentation; no code change)
• Breaking change (fix or feature that would cause existing functionality to change)
• Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

• I have read and agree to abide by the Code of Conduct
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and I have updated the documentation accordingly.
• I have added tests to cover my changes.
• I have added myself to the .zenodo.json document.
• I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

• I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

[KrisBecker]

Question: Is it recommended/possible to install isisdata_mockup.py in a bin-type directory or someplace where its easier to access/use?

[Kelvinrr]

some small comments.

Partly also my bad for being a little hasty with wanting to merge that PR.

[KrisBecker]

Any suggestions on where/how to install isisdata_mockup.py? This should be conveniently available to ISIS users if you decide to use this script as mechanism to validate ISISDATA installations.

[Kelvinrr]

@KrisBecker at the end of the CMakeLists.txt, you can add a line to install it to $INSTALL_PREFIX/bin/ with the .py stripped so we can run it as a command. That's how we've usually done these utility scripts we want common accesss to.

[KrisBecker]

Ok, so should I scrub all the docs to refer to the renamed extension-less version of the script? At least in the READMEs and the tests scripts?

[KrisBecker]

Commits install isisdata_mockup in $ISISROOT/bin (its not in build/bin). Had to finesse the permissions.

I also changed the test data mocking script to call this version.

This does create an issue for most of the documentation. It may be easier to just rename the script without the extension and change all the documentation appropriately otherwise I am concerned trying to retain the extension will lead to confusion.

[Kelvinrr]

That would be helpful, yes.

[KrisBecker]

Ok, renamed isisdata_mockup and modified docs/scripts to reflect the change.

This PR should be good to go now.

[KrisBecker]

Please let me know if there is anything else I need to do in order to get this PR merged.

Thank you.

[Kelvinrr]

Once merge conflicts are resolved I'll merge this.

[KrisBecker]

Merge conflict resolved in CHANGELOG.md and added an entry with these updates.

[Kelvinrr]

There is a random error after the merge conflicts were fixed in the test.

The following tests FAILED:
	1528 - DemCube.FunctionalTestSpiceinitWebAndShapeModel (Failed)

Might be a fluke so I am rerunning Jenkins for now.

[Kelvinrr]

the error is still there, it did show up after the last commit. But it is a Spiceinit error trying to hit the web server. Might have been down at the time the test ran coincidentally. I'll run one more time, if it still fails on that test it will probably have to be debugged.

[Kelvinrr]

aaaaaay it passed.