Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Ale 0.9.0 #5209

Merged
merged 3 commits into from
Jun 8, 2023
Merged

Update to Ale 0.9.0 #5209

merged 3 commits into from
Jun 8, 2023

Conversation

amystamile-usgs
Copy link
Contributor

@amystamile-usgs amystamile-usgs commented May 23, 2023

Description

In Draft mode until Ale 0.9.0 is push to anaconda.

Related Issue

How Has This Been Validated?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@amystamile-usgs amystamile-usgs marked this pull request as draft May 23, 2023 16:47
@acpaquette acpaquette marked this pull request as ready for review May 23, 2023 19:03
@acpaquette
Copy link
Collaborator

@amystamile-usgs @AustinSanders I converted this to ready for review to get jenkins running on it

@amystamile-usgs amystamile-usgs changed the title Draft: Update to Ale 0.9.0 Update to Ale 0.9.0 May 23, 2023
@amystamile-usgs
Copy link
Contributor Author

The following tests are failing in Jenkins:

Unit Tests
	 50 - isis_unit_test_Camera (Failed)
	 70 - isis_unit_test_DemShape (Failed)
	 72 - isis_unit_test_EllipsoidShape (Failed)
	 81 - isis_unit_test_EquatorialCylindricalShape (Failed)
	 97 - isis_unit_test_GroundGrid (Failed)
	266 - isis_unit_test_ShapeModel (Failed)
	1036 - mgs_unit_test_MocWideAngleCamera (Failed)
App Tests
	729 - spiceinit_app_test_shapemodel (Failed)
	1043 - mocproc_app_test_case01 (Failed)
	1044 - mocproc_app_test_case02 (Failed)
	1045 - mocproc_app_test_case03 (Failed)
Module Tests
	990 - lro_module_test_lroc (Failed)
	1032 - mex_module_test_hrsc (Failed)
	1047 - mgs_module_test_moc (Failed)

@acpaquette Not sure why all the shape model tests are failing

@acpaquette
Copy link
Collaborator

@amystamile-usgs Most of those tests use an MGS image and the MGS driver from ALE is getting picked up. There is some funky-ness in the MGS data which I am debugging now. We need to confirm some of these changes/address the differences before a release goes out

@acpaquette
Copy link
Collaborator

With the updated version of ALE all unit tests are passing.

For app tests only spiceinit_app_test_shapemodel is failing now but has been verified as acceptable changes.

All failing module tests have been verified and are okay to proceed.

CHANGELOG.md Outdated Show resolved Hide resolved
@acpaquette acpaquette merged commit f776dfc into DOI-USGS:dev Jun 8, 2023
acpaquette added a commit that referenced this pull request Jun 8, 2023
* Update to Ale 0.9.0

* Updated to ALE 0.9.1

* Updated changelog

---------

Co-authored-by: acpaquette <acpaquette@usgs.gov>
chkim-usgs added a commit that referenced this pull request Jun 22, 2023
* Update photomet's MinnaertEmpirical model to handle PVL input in photemplate format. Fixes #3621. (#5175)

* Update photomet's MinnaertEmpirical model to handle PVL input in photemplate format

* Updated CHANGELOG

* changed description for tgocassisrdrgen to be more descriptive than before (#5167)

* changed description for tgocassisrdrgen to be more descriptive than before.

* modifying the changelog to reflect doc changes

* fix typo

* Documentation fix for broken links in User Docs (#5182)

* doc changes for new links, need to scan other files for the same

* fixed remaining links

* typo

* fixed command line references link for ISIS3 Applications

* Update to Ale 0.9.0 (#5209)

* Update to Ale 0.9.0

* Updated to ALE 0.9.1

* Updated changelog

---------

Co-authored-by: acpaquette <acpaquette@usgs.gov>

* Updated meta.yaml to reflect 8.0.0 release (#5203)

* Updated meta.yaml to reflect 8.0.0 release

* Updated changelog

---------

Co-authored-by: acpaquette <acpaquette@usgs.gov>

* Test autolabeler

---------

Co-authored-by: Anton Hibl <75855379+antonhibl@users.noreply.github.com>
Co-authored-by: Amy Stamile <74275278+amystamile-usgs@users.noreply.github.com>
Co-authored-by: acpaquette <acpaquette@usgs.gov>
Co-authored-by: Austin Sanders <arsanders@usgs.gov>
chkim-usgs added a commit that referenced this pull request Jun 23, 2023
* Update photomet's MinnaertEmpirical model to handle PVL input in photemplate format. Fixes #3621. (#5175)

* Update photomet's MinnaertEmpirical model to handle PVL input in photemplate format

* Updated CHANGELOG

* changed description for tgocassisrdrgen to be more descriptive than before (#5167)

* changed description for tgocassisrdrgen to be more descriptive than before.

* modifying the changelog to reflect doc changes

* fix typo

* Documentation fix for broken links in User Docs (#5182)

* doc changes for new links, need to scan other files for the same

* fixed remaining links

* typo

* fixed command line references link for ISIS3 Applications

* Update to Ale 0.9.0 (#5209)

* Update to Ale 0.9.0

* Updated to ALE 0.9.1

* Updated changelog

---------

Co-authored-by: acpaquette <acpaquette@usgs.gov>

* Updated meta.yaml to reflect 8.0.0 release (#5203)

* Updated meta.yaml to reflect 8.0.0 release

* Updated changelog

---------

Co-authored-by: acpaquette <acpaquette@usgs.gov>

* Test autolabeler

* Try linking og issue

---------

Co-authored-by: Anton Hibl <75855379+antonhibl@users.noreply.github.com>
Co-authored-by: Amy Stamile <74275278+amystamile-usgs@users.noreply.github.com>
Co-authored-by: acpaquette <acpaquette@usgs.gov>
Co-authored-by: Austin Sanders <arsanders@usgs.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants