Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update csm plugins path in IsisPreferences #5397

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

chkim-usgs
Copy link
Contributor

Description

Updates the csm plugins path in IsisPreferences once usgscsm 2.0.0 gets conda released (pending feedstock PR here)

Related Issue

How Has This Been Validated?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@@ -178,7 +178,8 @@ EndGroup
########################################################

Group = Plugins
CSMDirectory = ("$ISISROOT/lib/isis/csm3.0.3/", -
CSMDirectory = ("$CONDA_PREFIX/lib/csmplugins", -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a trailing slash?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add it to be safe

@acpaquette acpaquette merged commit c1cc08a into DOI-USGS:dev Jan 8, 2024
chkim-usgs added a commit that referenced this pull request Jan 8, 2024
* Update csm plugins path in IsisPreferences

* Update changelog

* Add trailing slash
chkim-usgs added a commit that referenced this pull request Jan 10, 2024
* Update csm plugins path in IsisPreferences (#5397)

* Update csm plugins path in IsisPreferences

* Update changelog

* Add trailing slash

* 8.1.0_RC2 version ticks

* Moved changelog entry

* 8.1.0_RC2 Updates (#5399)

* 8.2.0_RC2 updates

* Changes for 8.1.0_RC2 (#5387)

* Fix dependency formatting in meta.yaml

* Pin gsl, update docs

* Revert pin

* Pin gsl to 2.6

* Add 8.1.0_RC1 as separate code entry

* Update the urls for 8.0 entry

* Turn on python bindings to be installed during build

* Add back kakadu build

* Add pybindings changelog entry

* Revert "Changes for 8.1.0_RC2 (#5387)"

This reverts commit 7994454.

* Bump ALE to 0.10.0

* Update csm plugins path from CONDA_PREFIX to ISISROOT

* Set build num to 0, add back rc1 code entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants