findfeaturessegment fixes #5439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lynn was able to test it locally (python script W since I just needed to send her the new python script) and seems to be working for her.
|
AustinSanders
approved these changes
Mar 25, 2024
| @@ -311,7 +313,6 @@ def findFeaturesSegment(ui): | |||
| else: | |||
| nthreads = int(multiprocessing.cpu_count()) | |||
|
|
|||
|
|
|||
| pool = ThreadPool(ceil(nthreads/len(img_list))) | |||
There was a problem hiding this comment.
Not part of the PR, but I just saw this line. Is this correct..? If the user passes in nthreads=8 and there are 8 images, then won't this end up with a threadpool of 1?
There was a problem hiding this comment.
I feel like there was a reason for that but in hindsight it doesn't make sense 🤔 I'll look into it some more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug where the app tries to merge cnets that failed to be created.
Related Issue
#5416
How Has This Been Validated?
Tested locally with the issue authors data and successfully created the control network.
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: