Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hrsc2isis support for level 3 images #5560

Merged
merged 5 commits into from
Jul 30, 2024
Merged

hrsc2isis support for level 3 images #5560

merged 5 commits into from
Jul 30, 2024

Conversation

amystamile-usgs
Copy link
Contributor

Description

Related Issue

closes #5497

How Has This Been Validated?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@amystamile-usgs
Copy link
Contributor Author

Looking into Hrsc2isis.Hrsc2IsisTestProjection test failure.

acpaquette
acpaquette reviewed Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, small suggestions

isis/src/mex/apps/hrsc2isis/hrsc2isis.cpp Show resolved Hide resolved
isis/src/mex/apps/hrsc2isis/hrsc2isis.xml Outdated Show resolved Hide resolved
acpaquette
acpaquette reviewed Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, one last grammar issue to fix

isis/src/mex/apps/hrsc2isis/hrsc2isis.xml Outdated Show resolved Hide resolved
@acpaquette
Copy link
Collaborator

@amystamile-usgs Small changelog conflict that needs to be resolved

@amystamile-usgs amystamile-usgs merged commit 9ac2592 into DOI-USGS:dev Jul 30, 2024
1 check passed
@github-actions github-actions bot added the bug Something isn't working label Jul 30, 2024
acpaquette pushed a commit to acpaquette/ISIS3 that referenced this pull request Jul 31, 2024
@amystamile-usgs @acpaquette
hrsc2isis support for level 3 images (DOI-USGS#5560)
ef97ff3 
* Remove label check for level3

* update changelog

* fix test

* addressed PR feedback

* fixed grammar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acpaquette acpaquette acpaquette approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HRSC level 3 images
2 participants
@amystamile-usgs @acpaquette