Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed typescript configuration #17

Merged
merged 3 commits into from
Sep 27, 2024
Merged

🐛 Fixed typescript configuration #17

merged 3 commits into from
Sep 27, 2024

Conversation

sadkebab
Copy link
Contributor

@sadkebab sadkebab commented Sep 23, 2024

  • Created a separated tsconfig file for the build step that includes only the src folder for emitted type declarations
  • Fixed type issues in tests/mock.test.ts
  • Adapted the headers of the mocked response to Web standards by returning an instance of Headers instead of an object (which caused a misleading type error in tests/mock.test.ts)

- Created a separated tsconfig file for the build step that includes only the `src` folder for emitted type declarations
- Fixed type issues in `tests/mock.test.ts`
- Adapted headers of the mocked response to web standards by returning an instance of Headers instead of an object
@sadkebab
Copy link
Contributor Author

@DRFR0ST the output of the build step seems to be working fine within the sandbox folder, it would be great if you double checked just in case.

@DRFR0ST
Copy link
Owner

DRFR0ST commented Sep 23, 2024

@sadkebab sure, will do. Thanks for the PR, I'll get to it later in the evening.

Copy link
Owner

@DRFR0ST DRFR0ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏻

@DRFR0ST DRFR0ST merged commit e2f784f into DRFR0ST:main Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants