Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks.yml repo linter requires token #116

Open
JosephGasiorekUSDS opened this issue Jul 5, 2024 · 0 comments · Fixed by #130
Open

checks.yml repo linter requires token #116

JosephGasiorekUSDS opened this issue Jul 5, 2024 · 0 comments · Fixed by #130

Comments

@JosephGasiorekUSDS
Copy link
Contributor

JosephGasiorekUSDS commented Jul 5, 2024

Issue Report

module-name: checks.yml repo linter requires token

Expected behavior

To be able to run the repo-scaffolder setup procedure for existing repos and have the checks work.

Actual behavior

The checks.yml workflow is set to run on pull requests. It then runs the newrelic/repolinter-action@v1 action with the output_type configuration set to issue instead of exit-code. The repolinter-action configuration requires a token value to be set with a valid Github Personal access token.

Steps to reproduce the behavior

Run the steps on an existing repo and and the checks won't pass. In my case the error message was:

Error: A fatal error was thrown.
Error: Octokit API call failed. This may be due to your token permissions or an issue with the GitHub API. If the error persists, feel free to open an issue.
Error: GET https://api.github.com/repos/XXXXX/XXXX/issues?creator=app%2Fgithub-actions&labels=cms-oss-tier4&state=all&sort=created&direction=desc returned status 403

I filed an issue instead of a PR as I was unsure of the preferred solution. Possible solutions include:

  • the output_type could be set to exit-code
  • add more steps to the setup procedure to create a token, add it to the secrets with the appropriate name
@IsaacMilarky IsaacMilarky linked a pull request Jul 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant