Fix Issues With Checks.yml workflow #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issues With Checks.yml workflow
Problem
The checks.yml file was not working when I was trying to use it on my recently generated repodive-tools repository
. It was failing to create the label for the desired issue properly.
Also, it doesn't make sense to run the checks.yml on pull requests because it is an action that is supposed to update an issue and issues are supposed to releflect the canon state of the project. If we run it on pending changes then the issue won't make sense.
Solution
Make the workflow run on push to main. Also use the main version of the
extendJSONFileworkflow instead of the dev version that didn't work. Also, add a standard api key to use for this action as a secret in the DSACMS org. I also removed the label logic from the checks.yml file because it wasn't working.