feat: Disable automatic service account mounting #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1414 +/- ##
=======================================
Coverage 74.77% 74.77%
=======================================
Files 169 169
Lines 5662 5662
Branches 656 656
=======================================
Hits 4234 4234
Misses 1280 1280
Partials 148 148 ☔ View full report in Codecov by Sentry. |
dominik003
approved these changes
Mar 21, 2024
Service accounts aren't needed for most of the services since they don't talk to the Kubernetes API. For increased security, we disable the automatic mounting of secrets.
MoritzWeber0
force-pushed
the
disable-serviceaccount-monting
branch
from
170db93
to
c4874e9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service accounts aren't needed for most of the services since they don't talk to the Kubernetes API.
For increased security, this disables the automatic mounting of secrets.