Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update user test to eliminate deprecation warning in request #1438

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

romeonicholas
Copy link
Contributor

Eliminates the following deprecation warning in test_create_user_removed_from_project_event.
https://www.python-httpx.org/compatibility/#request-content - "content" is preferred over "data" in this scenario

tests/test_event_creation.py::test_create_user_removed_from_project_event
/Users/nicholasromeo/code/capella-collab-manager/.venv/lib/python3.11/site-packages/httpx/_content.py:204: DeprecationWarning: Use 'content=<...>' to upload raw bytes/text content.
warnings.warn(message, DeprecationWarning)

Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.75%. Comparing base (aebe3cd) to head (24ab500).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1438   +/-   ##
=======================================
  Coverage   74.75%   74.75%           
=======================================
  Files         169      169           
  Lines        5656     5656           
  Branches      656      656           
=======================================
  Hits         4228     4228           
  Misses       1280     1280           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romeonicholas romeonicholas marked this pull request as ready for review March 19, 2024 10:36
Copy link
Contributor

@dominik003 dominik003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MoritzWeber0 MoritzWeber0 merged commit 20df4cd into main Mar 21, 2024
28 checks passed
@MoritzWeber0 MoritzWeber0 deleted the fix-test-deprecation-warning branch March 21, 2024 15:26
MoritzWeber0 added a commit that referenced this pull request Mar 21, 2024
fix: Update user test to eliminate deprecation warning in request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants