feat: Add tool info to session deletion dialog #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1448 +/- ##
=======================================
Coverage 74.75% 74.75%
=======================================
Files 169 169
Lines 5656 5656
Branches 656 656
=======================================
Hits 4228 4228
Misses 1280 1280
Partials 148 148 ☔ View full report in Codecov by Sentry. |
dominik003
force-pushed
the
feat-improve-session-deletion-dialog
branch
from
54f1dc3
to
c91126d
Compare
|
MoritzWeber0
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the tool information to the session termination dialog in the same format as it is displayed in the session card. This makes it easier for a user to identify which session is being closed when they click on "Terminate", as the ID is not known to the user. In addition, the empty css file has been removed and the new Angular control is now used in the component.