feat: Introduce McCabe complexity check #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1460 +/- ##
==========================================
+ Coverage 79.04% 79.35% +0.30%
==========================================
Files 172 172
Lines 5766 6016 +250
Branches 665 724 +59
==========================================
+ Hits 4558 4774 +216
- Misses 1054 1079 +25
- Partials 154 163 +9 ☔ View full report in Codecov by Sentry. |
|
MoritzWeber0
requested changes
Mar 27, 2024
dominik003
force-pushed
the
feat-add-mccabe-complexity-check
branch
from
e0f83d8
to
819f841
Compare
|
A Storybook preview is available for commit a44d6b2. |
MoritzWeber0
requested changes
May 15, 2024
MoritzWeber0
force-pushed
the
feat-add-mccabe-complexity-check
branch
from
819f841
to
7a4d9e8
Compare
MoritzWeber0
force-pushed
the
feat-add-mccabe-complexity-check
branch
from
7a4d9e8
to
9468ce9
Compare
|
MoritzWeber0
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the McCabe cyclomatic complexity check for pylint. This forces us not to make extensive use of nesting within functions, but to outsource parts to separate functions. For now we use the default threshold value of 10.
Resolves #1380