-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Standardize Message model and update messages to match #1467
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
==========================================
+ Coverage 79.04% 79.16% +0.11%
==========================================
Files 172 172
Lines 5766 5764 -2
Branches 665 665
==========================================
+ Hits 4558 4563 +5
+ Misses 1054 1047 -7
Partials 154 154 ☔ View full report in Codecov by Sentry. |
codecov/patch is failing, but the new code doesn't add or meaningfully change the existing functions, it looks like backend/capellacollab/settings/modelsources/t4c/repositories/routes.py is just already missing some coverage. |
6f53fce
to
6014155
Compare
Quality Gate passedIssues Measures |
6014155
to
0f07c17
Compare
A Storybook preview is available for commit 005e7ab. |
The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification. |
0f07c17
to
40488bc
Compare
Quality Gate passedIssues Measures |
The existing Message pydantic model used for warnings and errors was pretty loose and inconsistently used, this PR makes all fields required and updates all existing uses of the model.
I removed the techincal field because it was only used once or twice in places where exceptions were already being logged along with the warnings. err_code may also be unecessary, it's currently only being used in tests.