Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Standardize Message model and update messages to match #1467

Merged
merged 1 commit into from
May 27, 2024

Conversation

romeonicholas
Copy link
Contributor

The existing Message pydantic model used for warnings and errors was pretty loose and inconsistently used, this PR makes all fields required and updates all existing uses of the model.

I removed the techincal field because it was only used once or twice in places where exceptions were already being logged along with the warnings. err_code may also be unecessary, it's currently only being used in tests.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.16%. Comparing base (ff32d5f) to head (40488bc).
Report is 161 commits behind head on main.

Files Patch % Lines
...b/settings/modelsources/t4c/repositories/routes.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1467      +/-   ##
==========================================
+ Coverage   79.04%   79.16%   +0.11%     
==========================================
  Files         172      172              
  Lines        5766     5764       -2     
  Branches      665      665              
==========================================
+ Hits         4558     4563       +5     
+ Misses       1054     1047       -7     
  Partials      154      154              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romeonicholas romeonicholas marked this pull request as ready for review March 27, 2024 09:26
@romeonicholas
Copy link
Contributor Author

codecov/patch is failing, but the new code doesn't add or meaningfully change the existing functions, it looks like backend/capellacollab/settings/modelsources/t4c/repositories/routes.py is just already missing some coverage.

Copy link

sonarcloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MoritzWeber0 MoritzWeber0 marked this pull request as draft April 18, 2024 09:22
Copy link

github-actions bot commented May 22, 2024

A Storybook preview is available for commit 005e7ab.
View Storybook
View Chromatic build

Copy link

The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification.
Please run make openapi locally and commit the changes.

@MoritzWeber0 MoritzWeber0 marked this pull request as ready for review May 22, 2024 12:03
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MoritzWeber0 MoritzWeber0 merged commit 52cfc68 into main May 27, 2024
30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the standardize-messages branch May 27, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants