Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Disable font loading from Google fonts #1483

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

MoritzWeber0
Copy link
Member

Loading fonts from Google Fonts is not GDPR compliant. Instead, fall-back to the system font.

Loading fonts from Google Fonts is not GDPR compliant.
Instead, fall-back to the system font.
Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.94%. Comparing base (7197b80) to head (f8d2271).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1483      +/-   ##
==========================================
+ Coverage   76.92%   76.94%   +0.01%     
==========================================
  Files         170      170              
  Lines        5668     5668              
  Branches      650      650              
==========================================
+ Hits         4360     4361       +1     
+ Misses       1162     1161       -1     
  Partials      146      146              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@romeonicholas romeonicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch, of course the default would rely on google fonts. This branch fell back on my system fonts 👍

@MoritzWeber0 MoritzWeber0 merged commit 9cd30c0 into main Apr 5, 2024
26 checks passed
@MoritzWeber0 MoritzWeber0 deleted the inline-docs-fonts branch April 5, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants