Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show warning for archived projects #1495

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented Apr 5, 2024

Add better visibility for archived projects.

Archived projects were only visible via the "Archive" / "Unarchive" buttons for project admins and via the project overview for normal users. It was hard to see if an project is archived.

A Storybook styles.css was created to overwrite the default Storybook fonts, which had higher specificity than our Roboto font.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.94%. Comparing base (f7f4ce8) to head (7df8cf5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1495   +/-   ##
=======================================
  Coverage   76.94%   76.94%           
=======================================
  Files         170      170           
  Lines        5668     5668           
  Branches      650      650           
=======================================
  Hits         4361     4361           
  Misses       1161     1161           
  Partials      146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dominik003 dominik003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good to me. There are only two improvement comments that you may or may not apply, and one comment to add some more information to the PR/commit description regarding the general Storybook configuration changes.

Add better visibility for archived projects.

Archived projects were only visible via the "Archive" / "Unarchive"
buttons for project admins and via the project overview for normal
users. It was hard to see if an project is archived.
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Base automatically changed from storybook-project-metadata to main April 10, 2024 12:54
@MoritzWeber0 MoritzWeber0 merged commit 622c1fd into main Apr 10, 2024
14 checks passed
@MoritzWeber0 MoritzWeber0 deleted the archived-project-warning branch April 10, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants